Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751701AbdHCPV6 (ORCPT ); Thu, 3 Aug 2017 11:21:58 -0400 Received: from mail-yw0-f194.google.com ([209.85.161.194]:37104 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbdHCPV4 (ORCPT ); Thu, 3 Aug 2017 11:21:56 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170724212225.3426-1-jprvita@endlessm.com> <20170724212225.3426-3-jprvita@endlessm.com> <20170802121607.GA13659@mail.corp.redhat.com> From: =?UTF-8?Q?Jo=C3=A3o_Paulo_Rechi_Vita?= Date: Thu, 3 Aug 2017 08:21:15 -0700 Message-ID: Subject: Re: [PATCH 2/2] HID: multitouch: Support Asus T304UA media keys To: Jiri Kosina Cc: Benjamin Tissoires , Hans de Goede , linux@endlessm.com, =?UTF-8?Q?Jo=C3=A3o_Paulo_Rechi_Vita?= , linux-input@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v73FM41p022325 Content-Length: 1119 Lines: 29 On Thu, Aug 3, 2017 at 2:24 AM, Jiri Kosina wrote: > On Wed, 2 Aug 2017, Benjamin Tissoires wrote: > >> Sorry for the delay. I was at GUADEC the whole past week and couldn't >> get much kernel work done. I was thinking a little bit about this series >> though. Patch 1 is fine, but patch 2 is a little bit more of an issue. >> Ideally, I'd like to keep hid-multitouch from having too many vendor >> specific code, but it looks like this is the easier way to handle things >> here. >> >> I guess the proper way of solving this situation would be to merge the >> generic windows 8 code from hid-multitouch into hid-input so that other >> drivers can benefit from it, but this is going to be a lot of work and >> -ETIME. > > Yes, I actually have this on the list of things I'd eventually like to > look into one day ... but we shouldn't let this block any further > development. > > I have applied the series now to for-4.14/multitouch (fixing up the > 0xff310076 -> HID_VD_ASUS_CUSTOM_MEDIA_KEYS constant in the condition as a > followup). > Thanks! -- João Paulo Rechi Vita http://about.me/jprvita