Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751947AbdHCR1g (ORCPT ); Thu, 3 Aug 2017 13:27:36 -0400 Received: from casper.infradead.org ([85.118.1.10]:40134 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751656AbdHCR1e (ORCPT ); Thu, 3 Aug 2017 13:27:34 -0400 Date: Thu, 3 Aug 2017 18:27:29 +0100 (BST) From: James Simmons To: David Wittman cc: oleg.drokin@intel.com, andreas.dilger@intel.com, jinshan.xiong@intel.com, bobijam.xu@intel.com, gregkh@linuxfoundation.org, john.hammond@intel.com, di.wang@intel.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, lustre-devel@lists.lustre.org Subject: Re: [PATCH] staging: lustre: declare fiemap_for_stripe static In-Reply-To: <1501647591-22277-1-git-send-email-dwittman@gmail.com> Message-ID: References: <1501647591-22277-1-git-send-email-dwittman@gmail.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170803_182729_095769_14953C96 X-CRM114-Status: GOOD ( 11.93 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1529 Lines: 42 > Declare fiemap_for_stripe as static to fix sparse warnings: > > > warning: symbol 'fiemap_for_stripe' was not declared. Should it be > > static? Acked-by: James Simmons > Signed-off-by: David Wittman > --- > drivers/staging/lustre/lustre/lov/lov_object.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c > index 8fc0bcc..334ecb1 100644 > --- a/drivers/staging/lustre/lustre/lov/lov_object.c > +++ b/drivers/staging/lustre/lustre/lov/lov_object.c > @@ -1141,11 +1141,11 @@ struct fiemap_state { > bool fs_enough; > }; > > -int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj, > - struct lov_stripe_md *lsm, > - struct fiemap *fiemap, size_t *buflen, > - struct ll_fiemap_info_key *fmkey, int stripeno, > - struct fiemap_state *fs) > +static int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj, > + struct lov_stripe_md *lsm, > + struct fiemap *fiemap, size_t *buflen, > + struct ll_fiemap_info_key *fmkey, int stripeno, > + struct fiemap_state *fs) > { > struct cl_object *subobj; > struct lov_obd *lov = lu2lov_dev(obj->co_lu.lo_dev)->ld_lov; > -- > 2.7.4 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel >