Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751965AbdHCR5i (ORCPT ); Thu, 3 Aug 2017 13:57:38 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:36592 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751739AbdHCR5h (ORCPT ); Thu, 3 Aug 2017 13:57:37 -0400 From: Vince Weaver X-Google-Original-From: Vince Weaver Date: Thu, 3 Aug 2017 13:57:33 -0400 (EDT) X-X-Sender: vince@macbook-air To: "Naveen N. Rao" cc: Peter Zijlstra , Jiri Olsa , Arnaldo Carvalho de Melo , Ingo Molnar , Vince Weaver , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] kernel/events: Add option to notify through signals on wakeup In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 645 Lines: 17 On Tue, 1 Aug 2017, Naveen N. Rao wrote: > Add a new option 'signal_on_wakeup' to request for a signal to be > delivered on ring buffer wakeup controlled through watermark and > {wakeup_events, wakeup_watermark}. HUP is signaled on exit. > > Setting signal_on_wakeup disables use of IOC_REFRESH to control signal > delivery, instead relying on IOC_ENABLE/DISABLE. so I probably missed the original thread on this new interface, but why is IOC_REFRESH not being used? For new interfaces like this it's also nice to have some text that can be added to the perf_event_open() manpage, especially if there's weird conditions like this. Vince