Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751965AbdHCSIe (ORCPT ); Thu, 3 Aug 2017 14:08:34 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:34195 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751236AbdHCSIc (ORCPT ); Thu, 3 Aug 2017 14:08:32 -0400 Subject: Re: [PATCH v3 net-next 4/5] net: dsa: lan9303: Rename lan9303_xxx_packet_processing() To: Egil Hjelmeland , andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de References: <20170803094507.3439-1-privat@egil-hjelmeland.no> <20170803094507.3439-5-privat@egil-hjelmeland.no> From: Florian Fainelli Message-ID: <43501074-0e61-01f8-b856-bd22c65cf9e8@gmail.com> Date: Thu, 3 Aug 2017 11:08:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170803094507.3439-5-privat@egil-hjelmeland.no> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 515 Lines: 13 On 08/03/2017 02:45 AM, Egil Hjelmeland wrote: > The lan9303_enable_packet_processing, lan9303_disable_packet_processing > functions operate on port, so the names should reflect that. > And to align with lan9303_disable_processing(), rename: > > lan9303_enable_packet_processing -> lan9303_enable_processing_port > lan9303_disable_packet_processing -> lan9303_disable_processing_port > > Signed-off-by: Egil Hjelmeland Reviewed-by: Florian Fainelli -- Florian