Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751932AbdHCSyc (ORCPT ); Thu, 3 Aug 2017 14:54:32 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:36504 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751656AbdHCSya (ORCPT ); Thu, 3 Aug 2017 14:54:30 -0400 Date: Thu, 3 Aug 2017 13:54:28 -0500 From: Rob Herring To: Jiancheng Xue Cc: kishon@ti.com, xuwei5@hisilicon.com, catalin.marinas@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, hermit.wangheming@hisilicon.com, project-aspen-dev@linaro.org Subject: Re: [PATCH v2 1/4] dt-bindings: phy-hisi-inno-usb2: add support for hisi-inno-usb2 phy Message-ID: <20170803185428.a7h2k5u5ux6rebvc@rob-hp-laptop> References: <1501049163-18892-1-git-send-email-xuejiancheng@hisilicon.com> <1501049163-18892-2-git-send-email-xuejiancheng@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501049163-18892-2-git-send-email-xuejiancheng@hisilicon.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1174 Lines: 30 On Wed, Jul 26, 2017 at 02:06:00PM +0800, Jiancheng Xue wrote: > Add support for hisi-inno-usb2 phy. > > Signed-off-by: Jiancheng Xue > --- > .../devicetree/bindings/phy/phy-hisi-inno-usb2.txt | 31 ++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/phy-hisi-inno-usb2.txt > > diff --git a/Documentation/devicetree/bindings/phy/phy-hisi-inno-usb2.txt b/Documentation/devicetree/bindings/phy/phy-hisi-inno-usb2.txt > new file mode 100644 > index 0000000..417eeaa > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/phy-hisi-inno-usb2.txt > @@ -0,0 +1,31 @@ > +HiSilicon INNO USB2 PHY > +----------------------- > +Required properties: > +- compatible: Should be one of the following strings: > + "hisilicon,inno-usb2-phy", > + "hisilicon,hi3798cv200-usb2-phy", > +- #phy-cells: Shall be 0. > +- hisilicon,peripheral-syscon: Phandle of syscon used to control phy. > +- hisilicon,phycon-reg: Offset of the phy control register in the syscon. Just make this a cell of hisilicon,peripheral-syscon: <&syscon 0x120> With that, Acked-by: Rob Herring