Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751904AbdHCTCi (ORCPT ); Thu, 3 Aug 2017 15:02:38 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60500 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751251AbdHCTCf (ORCPT ); Thu, 3 Aug 2017 15:02:35 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 04 Aug 2017 00:32:33 +0530 From: Abhishek Sahu To: Boris Brezillon Cc: dwmw2@infradead.org, computersforpeace@gmail.com, marek.vasut@gmail.com, richard@nod.at, cyrille.pitchen@wedev4u.fr, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, architt@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-mtd@lists.infradead.org, andy.gross@linaro.org, sricharan@codeaurora.org Subject: Re: [PATCH v2 01/25] mtd: nand: qcom: fix config error for BCH In-Reply-To: <20170803204726.74f75aaa@bbrezillon> References: <1500464893-11352-1-git-send-email-absahu@codeaurora.org> <1500464893-11352-2-git-send-email-absahu@codeaurora.org> <20170803175602.3e0a4c18@bbrezillon> <20170803204726.74f75aaa@bbrezillon> Message-ID: <397c17de3aeafaea4295025f1c5d08e7@codeaurora.org> User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2305 Lines: 73 On 2017-08-04 00:17, Boris Brezillon wrote: > On Thu, 03 Aug 2017 23:22:37 +0530 > Abhishek Sahu wrote: > >> On 2017-08-03 21:26, Boris Brezillon wrote: >> > On Wed, 19 Jul 2017 17:17:49 +0530 >> > Abhishek Sahu wrote: >> > >> >> The configuration for BCH is not correct in the current driver. >> >> The ECC_CFG_ECC_DISABLE bit defines whether to enable or disable the >> >> BCH ECC in which >> >> >> >> 0x1 : BCH_DISABLED >> >> 0x0 : BCH_ENABLED >> >> >> >> But currently host->bch_enabled is being assined to BCH_DISABLED. >> >> >> >> Fixes: c76b78d8ec05a ("mtd: nand: Qualcomm NAND controller driver") >> >> Cc: stable@vger.kernel.org >> >> Signed-off-by: Abhishek Sahu >> >> --- >> >> drivers/mtd/nand/qcom_nandc.c | 4 ++-- >> >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> >> >> diff --git a/drivers/mtd/nand/qcom_nandc.c >> >> b/drivers/mtd/nand/qcom_nandc.c >> >> index 57d483a..bc0408c 100644 >> >> --- a/drivers/mtd/nand/qcom_nandc.c >> >> +++ b/drivers/mtd/nand/qcom_nandc.c >> >> @@ -1,5 +1,5 @@ >> >> /* >> >> - * Copyright (c) 2016, The Linux Foundation. All rights reserved. >> >> + * Copyright (c) 2016-2017, The Linux Foundation. All rights >> >> reserved. >> > >> > Hm, this copyright update is not really related to the changes you're >> > describing in the commit message. I'll drop this line from the commit >> > (no need to resend it) and ask you to send a separate patch updating >> > the >> > copyright. Is that ok? >> > >> >> The idea was to change the copyright year since we are making >> the changes in this file. If it requires separate patch, then I >> will do the same. > > Yes, I'd prefer a separate patch. Sure. will raise a separate patch > >> >> Also I need to change 'assined' -> assigned in commit text. > > Yep, already fixed that one. > >> I can >> update the patch and fix this. I am planning to send the v3 patches >> tomorrow which incorporates all the review comments. > > Can you wait a bit. I already applied some of your patches [1] and > would > like to finish my review. Thanks Boris. I will wait for it and will update my patch series accordingly. > > Thanks, > > Boris > > [1]https://github.com/bbrezillon/linux-0day/commits/nand/next