Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751931AbdHCURG (ORCPT <rfc822;w@1wt.eu>);
        Thu, 3 Aug 2017 16:17:06 -0400
Received: from aibo.runbox.com ([91.220.196.211]:53156 "EHLO aibo.runbox.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751600AbdHCURF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 3 Aug 2017 16:17:05 -0400
Subject: Re: [PATCH v3 net-next 3/5] net: dsa: lan9303: Simplify
 lan9303_xxx_packet_processing() usage
To: Florian Fainelli <f.fainelli@gmail.com>, andrew@lunn.ch,
        vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@pengutronix.de
References: <20170803094507.3439-1-privat@egil-hjelmeland.no>
 <20170803094507.3439-4-privat@egil-hjelmeland.no>
 <5a67a44b-6887-1466-c0f3-ce65759d51db@gmail.com>
From: Egil Hjelmeland <privat@egil-hjelmeland.no>
Message-ID: <00f388c1-f0ab-6780-9644-4bf66868682e@egil-hjelmeland.no>
Date: Thu, 3 Aug 2017 22:16:42 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <5a67a44b-6887-1466-c0f3-ce65759d51db@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1266
Lines: 35

Den 03. aug. 2017 20:06, skrev Florian Fainelli:
> On 08/03/2017 02:45 AM, Egil Hjelmeland wrote:
>> Simplify usage of lan9303_enable_packet_processing,
>> lan9303_disable_packet_processing()
>>
>> Signed-off-by: Egil Hjelmeland <privat@egil-hjelmeland.no>
> 
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> took a little while to figure out that we are utilizing fall through of
> the switch/case statement and that's why it's okay.
> 
>>
>>   static int lan9303_check_device(struct lan9303 *chip)
>> @@ -765,7 +766,6 @@ static int lan9303_port_enable(struct dsa_switch *ds, int port,
>>   	/* enable internal packet processing */
>>   	switch (port) {
>>   	case 1:
>> -		return lan9303_enable_packet_processing(chip, port);
>>   	case 2:
>>   		return lan9303_enable_packet_processing(chip, port);
>>   	default:

I suppose if we later change to dsa_switch_alloc(...,3), then it could
be further simplified to

if (port != 0)
	return lan9303_enable_packet_processing(chip, port);

Or perhaps no test is needed at all. The driver assumes port 0 is cpu
port, which is the sensible way to use the chip. (Because port 0 has
no phy, the others have phy). Declaring a different port as cpu port in
DTS will not work, but it will not crash the kernel.

Egil