Date: Thu, 3 Aug 2017 15:27:34 -0500
From: Rob Herring <robh@kernel.org>
To: divagar.mohandass@intel.com
Cc: mark.rutland@arm.com, wsa@the-dreams.de, devicetree@vger.kernel.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        rajmohan.mani@intel.com
Subject: Re: [PATCH 1/3] dt-bindings: add "size" property.
Message-ID: <20170803202734.rqyoiqhqvonvvtca@rob-hp-laptop>
References: <1501173789-25959-1-git-send-email-divagar.mohandass@intel.com>
 <1501173789-25959-2-git-send-email-divagar.mohandass@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1501173789-25959-2-git-send-email-divagar.mohandass@intel.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1130
Lines: 32

On Thu, Jul 27, 2017 at 10:13:07PM +0530, divagar.mohandass@intel.com wrote:
> From: Divagar Mohandass <divagar.mohandass@intel.com>

Please improve the subject. Add size to what?

> 
> This adds "size" as optional property for i2c eeproms.
> 
> "size" should be mentioned in byte and it should refer
> to the eeprom size. This will be read by the driver and
> used to calculating the number of bytes in read/write calls.
> 
> Signed-off-by: Divagar Mohandass <divagar.mohandass@intel.com>
> ---
>  Documentation/devicetree/bindings/eeprom/eeprom.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> index 5696eb5..1436569 100644
> --- a/Documentation/devicetree/bindings/eeprom/eeprom.txt
> +++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> @@ -32,6 +32,8 @@ Optional properties:
>  
>    - read-only: this parameterless property disables writes to the eeprom
>  
> +  - size: total eeprom size in bytes
> +

This should be implied by the compatible string of the eeprom. Why do 
you need this?

Rob