Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752111AbdHCVnK (ORCPT ); Thu, 3 Aug 2017 17:43:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44734 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbdHCVnI (ORCPT ); Thu, 3 Aug 2017 17:43:08 -0400 Date: Thu, 3 Aug 2017 14:43:06 -0700 From: Greg KH To: Himanshu Jha Cc: johan@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Drivers: usb: serial: Replace unsigned to unsigned int and fix line over 80 characters Message-ID: <20170803214306.GB358@kroah.com> References: <1501793473-32107-1-git-send-email-himanshujha199640@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501793473-32107-1-git-send-email-himanshujha199640@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 713 Lines: 20 On Fri, Aug 04, 2017 at 02:21:13AM +0530, Himanshu Jha wrote: > This patch fixes the following checkpatch.pl warnings: > > WARNING: Block comments use * on subsequent lines > WARNING: Block comments use a trailing */ on a separate line > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > WARNING: Missing a blank line after declarations > WARNING: line over 80 characters > > Signed-off-by: Himanshu Jha > --- > drivers/usb/serial/ch341.c | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) Note, I'm not Johan, but I only take patches that do one thing at a time, and no, "fixing all coding style issues" is not one thing :) thanks, greg k-h