Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752024AbdHCWRJ (ORCPT ); Thu, 3 Aug 2017 18:17:09 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:34537 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751791AbdHCWRH (ORCPT ); Thu, 3 Aug 2017 18:17:07 -0400 MIME-Version: 1.0 In-Reply-To: References: From: "Rafael J. Wysocki" Date: Fri, 4 Aug 2017 00:17:06 +0200 X-Google-Sender-Auth: bhRyzv_GcckKWEbYtC-MGFHClo8 Message-ID: Subject: Re: [PATCH] ACPI / dock: constify attribute_group structures. To: Arvind Yadav Cc: "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1134 Lines: 33 On Thu, Aug 3, 2017 at 3:18 PM, Arvind Yadav wrote: > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by work with > const attribute_group. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Somebody else sent an analogous patch earlier, so I'm going to take that one. > --- > drivers/acpi/dock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c > index 0c00208..2305e1a 100644 > --- a/drivers/acpi/dock.c > +++ b/drivers/acpi/dock.c > @@ -585,7 +585,7 @@ static ssize_t show_dock_type(struct device *dev, > NULL > }; > > -static struct attribute_group dock_attribute_group = { > +static const struct attribute_group dock_attribute_group = { > .attrs = dock_attributes > }; > > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html