Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751964AbdHDDPn (ORCPT <rfc822;w@1wt.eu>);
        Thu, 3 Aug 2017 23:15:43 -0400
Received: from [140.206.112.106] ([140.206.112.106]:53301 "EHLO
        mail2012.asrmicro.com" rhost-flags-FAIL-FAIL-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751845AbdHDDPm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 3 Aug 2017 23:15:42 -0400
Subject: Re: [Question]: try to fix contention between expire_timers and
 try_to_del_timer_sync
To: Vikram Mulukutla <markivx@codeaurora.org>
CC: Will Deacon <will.deacon@arm.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        John Stultz <john.stultz@linaro.org>, <sboyd@codeaurora.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Wang Wilbur <wilburwang@asrmicro.com>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        <linux-kernel-owner@vger.kernel.org>, <sudeep.holla@arm.com>
References: <3d2459c7-defd-a47e-6cea-007c10cecaac@asrmicro.com>
 <alpine.DEB.2.20.1707261548560.2186@nanos>
 <dcb18367-c747-96a8-9927-d8ba6954c496@asrmicro.com>
 <e1cc02c5e7dfd4d6bec937b6dc97bfc7@codeaurora.org>
 <20170728092831.GA24839@arm.com>
 <2aa9684cf9c889ee9fdc8550b4388af6@codeaurora.org>
 <1c951f01-c450-d21b-13e9-6a32eb509d94@asrmicro.com>
 <c2450453-0a42-0c68-db9b-3d097dc62c34@asrmicro.com>
 <a1530fab213076be576adce4d5fbbb44@codeaurora.org>
From: qiaozhou <qiaozhou@asrmicro.com>
Message-ID: <f634d966-c101-65c6-af4f-bd9d46cf5be2@asrmicro.com>
Date: Fri, 4 Aug 2017 11:15:08 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <a1530fab213076be576adce4d5fbbb44@codeaurora.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.1.50.16]
X-ClientProxiedBy: mail2012.asrmicro.com (10.1.24.123) To
 mail2012.asrmicro.com (10.1.24.123)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2264
Lines: 65



On 2017年08月04日 07:32, Vikram Mulukutla wrote:
> 
> Hi Qiao,
> 
> 
> On 2017-08-01 00:37, qiaozhou wrote:
>> On 2017年07月31日 19:20, qiaozhou wrote:
>>>
>>>
> 
> <snip>
> 
>>>> =====================================================
>>>> Also apply Vikram's patch and have a test.
>>
>> cpu2: a53, 832MHz, cpu7: a73, 1.75Hz
>> Without cpu_relax bodging patch
>> =====================================================
>> cpu2 time | cpu2 counter | cpu7 time | cpu7 counter |
>> ==========|==============|===========|==============|
>>      16505|          5243|          2|      12487322|
>>      16494|          5619|          1|      12013291|
>>      16498|          5276|          2|      11706824|
>>      16494|          7123|          1|      12532355|
>>      16470|          7208|          2|      11784617|
>> =====================================================
>>
>> cpu2: a53, 832MHz, cpu7: a73, 1.75Hz
>> With cpu_relax bodging patch:
>> =====================================================
>> cpu2 time | cpu2 counter | cpu7 time | cpu7 counter |
>> ==========|==============|===========|==============|
>>       3991|        140714|          1|      11430528|
>>       4018|        144371|          1|      11430528|
>>       4034|        143250|          1|      11427011|
>>       4330|        147345|          1|      11423583|
>>       4752|        138273|          1|      11433241|
>> =====================================================
>>
>> It has some improvements, but not so good as Vikram's data. The big
>> core still has much more chance to acquire lock.
>>>>
>>>> Thanks,
>>>> Vikram
>>>>
> 
> Thanks for your data! I'll check on one of our other platforms to see
> if I see similar behavior. This may have something to do with the
> event-stream on your platform or the A53 revision as Sudeep pointed
> out here [1] - something to check I suppose...
Thanks for the reminder. Our HW IP has already fixed the bug Sudeep 
mentioned. I'm also checking the global exclusive monitor implementation 
on our platform with our ASIC guys, and it might be related with snoop 
transaction, or implement details in global exclusive monitor.

Thanks a lot.
Qiao
> 
> Thanks,
> Vikram
> 
> [1] - https://lkml.org/lkml/2016/11/21/458
>