Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751321AbdHDHLb (ORCPT ); Fri, 4 Aug 2017 03:11:31 -0400 Received: from gir.skynet.ie ([193.1.99.77]:49791 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751274AbdHDHLa (ORCPT ); Fri, 4 Aug 2017 03:11:30 -0400 X-Greylist: delayed 579 seconds by postgrey-1.27 at vger.kernel.org; Fri, 04 Aug 2017 03:11:29 EDT Date: Fri, 4 Aug 2017 08:01:46 +0100 (IST) From: Dave Airlie X-X-Sender: airlied@skynet.skynet.ie To: Arvind Yadav cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/10] agp: uninorth: constify pci_device_id. In-Reply-To: <1501603317-22947-2-git-send-email-arvind.yadav.cs@gmail.com> Message-ID: References: <1501603317-22947-1-git-send-email-arvind.yadav.cs@gmail.com> <1501603317-22947-2-git-send-email-arvind.yadav.cs@gmail.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 960 Lines: 31 On Tue, 1 Aug 2017, Arvind Yadav wrote: > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav I've merged all the agp ones into drm-next. Dave. > --- > drivers/char/agp/uninorth-agp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-agp.c > index fdced54..c381c8e 100644 > --- a/drivers/char/agp/uninorth-agp.c > +++ b/drivers/char/agp/uninorth-agp.c > @@ -679,7 +679,7 @@ static void agp_uninorth_remove(struct pci_dev *pdev) > agp_put_bridge(bridge); > } > > -static struct pci_device_id agp_uninorth_pci_table[] = { > +static const struct pci_device_id agp_uninorth_pci_table[] = { > { > .class = (PCI_CLASS_BRIDGE_HOST << 8), > .class_mask = ~0, >