Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751362AbdHDHrA (ORCPT ); Fri, 4 Aug 2017 03:47:00 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:50326 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751278AbdHDHq7 (ORCPT ); Fri, 4 Aug 2017 03:46:59 -0400 Date: Fri, 4 Aug 2017 09:46:56 +0200 From: Boris Brezillon To: Abhishek Sahu Cc: dwmw2@infradead.org, computersforpeace@gmail.com, marek.vasut@gmail.com, richard@nod.at, cyrille.pitchen@wedev4u.fr, robh+dt@kernel.org, mark.rutland@arm.com, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, andy.gross@linaro.org, architt@codeaurora.org, sricharan@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH v2 01/25] mtd: nand: qcom: fix config error for BCH Message-ID: <20170804094656.56184d79@bbrezillon> In-Reply-To: <1500464893-11352-2-git-send-email-absahu@codeaurora.org> References: <1500464893-11352-1-git-send-email-absahu@codeaurora.org> <1500464893-11352-2-git-send-email-absahu@codeaurora.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1568 Lines: 42 On Wed, 19 Jul 2017 17:17:49 +0530 Abhishek Sahu wrote: > The configuration for BCH is not correct in the current driver. > The ECC_CFG_ECC_DISABLE bit defines whether to enable or disable the > BCH ECC in which > > 0x1 : BCH_DISABLED > 0x0 : BCH_ENABLED > > But currently host->bch_enabled is being assined to BCH_DISABLED. > > Fixes: c76b78d8ec05a ("mtd: nand: Qualcomm NAND controller driver") > Cc: stable@vger.kernel.org > Signed-off-by: Abhishek Sahu > --- > drivers/mtd/nand/qcom_nandc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/qcom_nandc.c b/drivers/mtd/nand/qcom_nandc.c > index 57d483a..bc0408c 100644 > --- a/drivers/mtd/nand/qcom_nandc.c > +++ b/drivers/mtd/nand/qcom_nandc.c > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2016, The Linux Foundation. All rights reserved. > + * Copyright (c) 2016-2017, The Linux Foundation. All rights reserved. Applied to nand/next after removing the above line. > * > * This software is licensed under the terms of the GNU General Public > * License version 2, as published by the Free Software Foundation, and > @@ -1893,7 +1893,7 @@ static int qcom_nand_host_setup(struct qcom_nand_host *host) > | wide_bus << WIDE_FLASH > | 1 << DEV0_CFG1_ECC_DISABLE; > > - host->ecc_bch_cfg = host->bch_enabled << ECC_CFG_ECC_DISABLE > + host->ecc_bch_cfg = !host->bch_enabled << ECC_CFG_ECC_DISABLE > | 0 << ECC_SW_RESET > | host->cw_data << ECC_NUM_DATA_BYTES > | 1 << ECC_FORCE_CLK_OPEN