Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752011AbdHDIxR (ORCPT ); Fri, 4 Aug 2017 04:53:17 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:52158 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751306AbdHDIxP (ORCPT ); Fri, 4 Aug 2017 04:53:15 -0400 Date: Fri, 4 Aug 2017 10:53:04 +0200 From: Boris Brezillon To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, Archit Taneja , Andrzej Hajda , Laurent Pinchart , Thierry Reding , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/6] drm/vc4: Avoid using vrefresh==0 mode in DSI htotal math. Message-ID: <20170804105304.68e3b02a@bbrezillon> In-Reply-To: <20170718210510.12229-1-eric@anholt.net> References: <20170718210510.12229-1-eric@anholt.net> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1638 Lines: 41 On Tue, 18 Jul 2017 14:05:05 -0700 Eric Anholt wrote: > The incoming mode might have a missing vrefresh field if it came from > drmModeSetCrtc(), which the kernel is supposed to calculate using > drm_mode_vrefresh(). We could either use that or the adjusted_mode's > original vrefresh value. > > However, we can maintain a more exact vrefresh value (not just the > integer approximation), by scaling by the ratio of our clocks. > > v2: Use math suggested by Andrzej Hajda instead. > > Signed-off-by: Eric Anholt > --- > drivers/gpu/drm/vc4/vc4_dsi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c > index 629d372633e6..57213f4e3c72 100644 > --- a/drivers/gpu/drm/vc4/vc4_dsi.c > +++ b/drivers/gpu/drm/vc4/vc4_dsi.c > @@ -866,7 +866,8 @@ static bool vc4_dsi_encoder_mode_fixup(struct drm_encoder *encoder, > adjusted_mode->clock = pixel_clock_hz / 1000 + 1; > > /* Given the new pixel clock, adjust HFP to keep vrefresh the same. */ > - adjusted_mode->htotal = pixel_clock_hz / (mode->vrefresh * mode->vtotal); > + adjusted_mode->htotal = (pixel_clock_hz / 1000 * mode->htotal / > + mode->clock); Hm, I'm not sure I understand this. Shouldn't we have something like: adjusted_mode->htotal = (adjusted_mode->clock * mode->htotal) / mode->clock; Is there a reason for doing '+ 1' when you calculate the adjusted pixel clock rate but not here? > adjusted_mode->hsync_end += adjusted_mode->htotal - mode->htotal; > adjusted_mode->hsync_start += adjusted_mode->htotal - mode->htotal; >