Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752059AbdHDKBs (ORCPT ); Fri, 4 Aug 2017 06:01:48 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:54023 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751292AbdHDKBr (ORCPT ); Fri, 4 Aug 2017 06:01:47 -0400 Date: Fri, 4 Aug 2017 12:01:45 +0200 From: Boris Brezillon To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown. Message-ID: <20170804120145.4442647b@bbrezillon> In-Reply-To: <20170802203242.12815-1-eric@anholt.net> References: <20170802203242.12815-1-eric@anholt.net> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1039 Lines: 30 On Wed, 2 Aug 2017 13:32:40 -0700 Eric Anholt wrote: > It's also destroyed from the top level vc4_drv.c initialization, which > is where the cache was actually initialized from. > > This used to just involve duplicate del_timer() and cancel_work_sync() > being called, but it started causing kmalloc issues once we > double-freed the new BO label array. > > Fixes: 1908a876f909 ("drm/vc4: Add an ioctl for labeling GEM BOs for summary stats") > Signed-off-by: Eric Anholt Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_gem.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c > index 209fccd0d3b4..892a031a3ced 100644 > --- a/drivers/gpu/drm/vc4/vc4_gem.c > +++ b/drivers/gpu/drm/vc4/vc4_gem.c > @@ -1117,6 +1117,4 @@ vc4_gem_destroy(struct drm_device *dev) > > if (vc4->hang_state) > vc4_free_hang_state(dev, vc4->hang_state); > - > - vc4_bo_cache_destroy(dev); > }