Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752095AbdHDKCo (ORCPT ); Fri, 4 Aug 2017 06:02:44 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:54044 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751292AbdHDKCn (ORCPT ); Fri, 4 Aug 2017 06:02:43 -0400 Date: Fri, 4 Aug 2017 12:02:41 +0200 From: Boris Brezillon To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] drm/vc4: Don't disable DSI clocks on component unload. Message-ID: <20170804120241.3fe6889a@bbrezillon> In-Reply-To: <20170802203242.12815-2-eric@anholt.net> References: <20170802203242.12815-1-eric@anholt.net> <20170802203242.12815-2-eric@anholt.net> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 956 Lines: 29 On Wed, 2 Aug 2017 13:32:41 -0700 Eric Anholt wrote: > The clocks are enabled/disabled at encoder enable/disable time, not at > component load. Fixes a WARN_ON at boot if V3D fails to probe. > > Fixes: 4078f5757144 ("drm/vc4: Add DSI driver") > Signed-off-by: Eric Anholt Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_dsi.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c > index 629d372633e6..13481bb6322f 100644 > --- a/drivers/gpu/drm/vc4/vc4_dsi.c > +++ b/drivers/gpu/drm/vc4/vc4_dsi.c > @@ -1641,9 +1641,6 @@ static void vc4_dsi_unbind(struct device *dev, struct device *master, > > mipi_dsi_host_unregister(&dsi->dsi_host); > > - clk_disable_unprepare(dsi->pll_phy_clock); > - clk_disable_unprepare(dsi->escape_clock); > - > if (dsi->port == 1) > vc4->dsi1 = NULL; > }