Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752050AbdHDKIS (ORCPT ); Fri, 4 Aug 2017 06:08:18 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:54295 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751290AbdHDKIR (ORCPT ); Fri, 4 Aug 2017 06:08:17 -0400 Date: Fri, 4 Aug 2017 12:08:15 +0200 From: Boris Brezillon To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI. Message-ID: <20170804120815.4a1d149c@bbrezillon> In-Reply-To: <20170802203242.12815-3-eric@anholt.net> References: <20170802203242.12815-1-eric@anholt.net> <20170802203242.12815-3-eric@anholt.net> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 948 Lines: 30 On Wed, 2 Aug 2017 13:32:42 -0700 Eric Anholt wrote: > drm_bridge_remove() is for unregistering a bridge driver, not for s/driver/device/ > detaching a bridge from its consumer. > > Fixes: 656fa22f9cea ("drm/vc4: Switch DSI to the panel-bridge layer, and support bridges.") > Signed-off-by: Eric Anholt Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_dsi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c > index 13481bb6322f..d1e0dc908048 100644 > --- a/drivers/gpu/drm/vc4/vc4_dsi.c > +++ b/drivers/gpu/drm/vc4/vc4_dsi.c > @@ -1636,7 +1636,6 @@ static void vc4_dsi_unbind(struct device *dev, struct device *master, > > pm_runtime_disable(dev); > > - drm_bridge_remove(dsi->bridge); > vc4_dsi_encoder_destroy(dsi->encoder); > > mipi_dsi_host_unregister(&dsi->dsi_host);