Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752010AbdHDKKf (ORCPT ); Fri, 4 Aug 2017 06:10:35 -0400 Received: from mga01.intel.com ([192.55.52.88]:26795 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751290AbdHDKKd (ORCPT ); Fri, 4 Aug 2017 06:10:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,320,1498546800"; d="scan'208";a="295734791" Date: Fri, 4 Aug 2017 13:10:29 +0300 From: Mika Westerberg To: Jan Kiszka Cc: Mark Brown , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Andy Shevchenko , linux-spi , Linux Kernel Mailing List , linux-arm-kernel Subject: Re: [PATCH RFC 1/2] spi: pxa2xx: Convert to GPIO descriptor API where possible Message-ID: <20170804101029.GV2369@lahna.fi.intel.com> References: <6bfd2b29b888c14f1a6feb9dee5bb54b74e761b0.1501760433.git.jan.kiszka@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6bfd2b29b888c14f1a6feb9dee5bb54b74e761b0.1501760433.git.jan.kiszka@siemens.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 592 Lines: 15 On Thu, Aug 03, 2017 at 01:40:32PM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > We still need to request/free GPIOs passed via the legacy path of > pxa2xx_spi_chip::gpio_cs, but we can use the gpiod API otherwise. > > Consistently use the descriptor API instead of the legacy one. > > Signed-off-by: Jan Kiszka There are some PXA2xx platforms under arch/arm/* which use this driver and legacy GPIOs. I wonder if this causes any problems with them? That was one of the reasons I did not convert the whole driver over GPIO descriptors.