Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751944AbdHDKOe (ORCPT <rfc822;w@1wt.eu>);
        Fri, 4 Aug 2017 06:14:34 -0400
Received: from mailgw01.mediatek.com ([210.61.82.183]:4774 "EHLO
        mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
        with ESMTP id S1751285AbdHDKOc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 4 Aug 2017 06:14:32 -0400
Message-ID: <1501841664.17551.2.camel@mtkswgap22>
Subject: Re: [PATCH v4 1/2] arm: dts: mt7623: Add SD-card and EMMC to
 bananapi-r2
From: Sean Wang <sean.wang@mediatek.com>
To: <matthias.bgg@gmail.com>
CC: <robh+dt@kernel.org>, <mark.rutland@arm.com>,
        <devicetree@vger.kernel.org>, <linux-mediatek@lists.infradead.org>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Date: Fri, 4 Aug 2017 18:14:24 +0800
In-Reply-To: <1c83eae1944992f7c5a9af946e03bc2c4e62c874.1501819056.git.sean.wang@mediatek.com>
References: <1c83eae1944992f7c5a9af946e03bc2c4e62c874.1501819056.git.sean.wang@mediatek.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2112
Lines: 79

On Fri, 2017-08-04 at 11:59 +0800, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
> 
> The bananapi-r2 board has an SD-card controller and built-in
> EMMC storage so enables those devices in the devicetree. Also
> cleanup nodes in alphabetical order in the patch.
> 

Hi, Matthias

could your help remove those words "Also cleanup nodes in alphabetical
order in the patch." when merging, i was forgetting to do it.

or prefer wanting me to resend it again?

	Sean

> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---
>  arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 37 +++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> index 9f3e6dd..444ed93 100644
> --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> @@ -179,6 +179,32 @@
>  	status = "okay";
>  };
>  
> +&mmc0 {
> +	pinctrl-names = "default", "state_uhs";
> +	pinctrl-0 = <&mmc0_pins_default>;
> +	pinctrl-1 = <&mmc0_pins_uhs>;
> +	status = "okay";
> +	bus-width = <8>;
> +	max-frequency = <50000000>;
> +	cap-mmc-highspeed;
> +	vmmc-supply = <&mt6323_vemc3v3_reg>;
> +	vqmmc-supply = <&mt6323_vio18_reg>;
> +	non-removable;
> +};
> +
> +&mmc1 {
> +	pinctrl-names = "default", "state_uhs";
> +	pinctrl-0 = <&mmc1_pins_default>;
> +	pinctrl-1 = <&mmc1_pins_uhs>;
> +	status = "okay";
> +	bus-width = <4>;
> +	max-frequency = <50000000>;
> +	cap-sd-highspeed;
> +	cd-gpios = <&pio 261 0>;
> +	vmmc-supply = <&mt6323_vmch_reg>;
> +	vqmmc-supply = <&mt6323_vio18_reg>;
> +};
> +
>  &pio {
>  	cir_pins_a:cir@0 {
>  		pins_cir {
> @@ -314,6 +340,17 @@
>  			bias-pull-down;
>  			drive-strength = <MTK_DRIVE_4mA>;
>  		};
> +
> +		pins_wp {
> +			pinmux = <MT7623_PIN_29_EINT7_FUNC_MSDC1_WP>;
> +			input-enable;
> +			bias-pull-up;
> +		};
> +
> +		pins_insert {
> +			pinmux = <MT7623_PIN_261_MSDC1_INS_FUNC_GPIO261>;
> +			bias-pull-up;
> +		};
>  	};
>  
>  	mmc1_pins_uhs: mmc1 {