Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752034AbdHDKTH (ORCPT ); Fri, 4 Aug 2017 06:19:07 -0400 Received: from thoth.sbs.de ([192.35.17.2]:57187 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbdHDKTF (ORCPT ); Fri, 4 Aug 2017 06:19:05 -0400 Subject: Re: [PATCH RFC 1/2] spi: pxa2xx: Convert to GPIO descriptor API where possible To: Mika Westerberg Cc: Mark Brown , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Andy Shevchenko , linux-spi , Linux Kernel Mailing List , linux-arm-kernel References: <6bfd2b29b888c14f1a6feb9dee5bb54b74e761b0.1501760433.git.jan.kiszka@siemens.com> <20170804101029.GV2369@lahna.fi.intel.com> From: Jan Kiszka Message-ID: Date: Fri, 4 Aug 2017 12:18:28 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20170804101029.GV2369@lahna.fi.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 935 Lines: 26 On 2017-08-04 12:10, Mika Westerberg wrote: > On Thu, Aug 03, 2017 at 01:40:32PM +0200, Jan Kiszka wrote: >> From: Jan Kiszka >> >> We still need to request/free GPIOs passed via the legacy path of >> pxa2xx_spi_chip::gpio_cs, but we can use the gpiod API otherwise. >> >> Consistently use the descriptor API instead of the legacy one. >> >> Signed-off-by: Jan Kiszka > > There are some PXA2xx platforms under arch/arm/* which use this driver > and legacy GPIOs. I wonder if this causes any problems with them? > > That was one of the reasons I did not convert the whole driver over GPIO > descriptors. It shouldn't cause problems (famous last words) because I refrained from changing the interfaces to them. References that come in as legacy GPIO are still treated like that. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux