Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751519AbdHDKWq (ORCPT ); Fri, 4 Aug 2017 06:22:46 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:33750 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751278AbdHDKWo (ORCPT ); Fri, 4 Aug 2017 06:22:44 -0400 Subject: Re: [Intel-gfx] [PATCH 00/11] constify i915 attribute_group structures. To: Lionel Landwerlin , daniel.vetter@intel.com, jani.nikula@linux.intel.com, airlied@linux.ie References: <1501823016-6779-1-git-send-email-arvind.yadav.cs@gmail.com> <64fe44aa-7827-e81e-835f-c50a8cbe4021@intel.com> Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org From: Arvind Yadav Message-ID: <472019e3-ef75-4041-0717-f6eeec178214@gmail.com> Date: Fri, 4 Aug 2017 15:52:29 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <64fe44aa-7827-e81e-835f-c50a8cbe4021@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2775 Lines: 75 Hi Lionel, On Friday 04 August 2017 02:33 PM, Lionel Landwerlin wrote: > Hi Arwind, > > These files were generated by a script maintained in this repository : > https://github.com/rib/gputop/blob/master/scripts/i915-perf-kernelgen.py > It would best to update this script first to make sure future > platforms get the fixes too. > > Some changes have just been merged, deleted most configs but the test > ones. > You'll need to update your series. > I have done the changes. Please review it. :) Shared patch is 0001-i915-perf-kernelgen.py-constify-attribute_group-stru.patch. > Otherwise it looks like a good change. > > Thanks, > > - > Lionel > > On 04/08/17 06:03, Arvind Yadav wrote: >> attribute_group are not supposed to change at runtime. All functions >> working with attribute_group provided by work with >> const attribute_group. So mark the non-const structs as const. >> >> Arvind Yadav (11): >> [PATCH 01/11] drm: i915: i915_oa_kblgt2: constify attribute_group >> structures. >> [PATCH 02/11] drm: i915: i915_oa_bdw: constify attribute_group >> structures. >> [PATCH 03/11] drm: i915: i915_oa_bxt: constify attribute_group >> structures. >> [PATCH 04/11] drm: i915: i915_oa_chv: constify attribute_group >> structures. >> [PATCH 05/11] drm: i915: i915_oa_glk: constify attribute_group >> structures. >> [PATCH 06/11] drm: i915: i915_oa_hsw: constify attribute_group >> structures. >> [PATCH 07/11] drm: i915: i915_oa_kblgt3: constify attribute_group >> structures. >> [PATCH 08/11] drm: i915: i915_oa_sklgt2: constify attribute_group >> structures. >> [PATCH 09/11] drm: i915: i915_oa_sklgt3: constify attribute_group >> structures. >> [PATCH 10/11] drm: i915: i915_oa_sklgt4: constify attribute_group >> structures. >> [PATCH 11/11] drm: i915: i915_sysfs: constify attribute_group >> structures. >> >> drivers/gpu/drm/i915/i915_oa_bdw.c | 44 >> +++++++++++++++++------------------ >> drivers/gpu/drm/i915/i915_oa_bxt.c | 30 ++++++++++++------------ >> drivers/gpu/drm/i915/i915_oa_chv.c | 28 +++++++++++----------- >> drivers/gpu/drm/i915/i915_oa_glk.c | 30 ++++++++++++------------ >> drivers/gpu/drm/i915/i915_oa_hsw.c | 12 +++++----- >> drivers/gpu/drm/i915/i915_oa_kblgt2.c | 36 >> ++++++++++++++-------------- >> drivers/gpu/drm/i915/i915_oa_kblgt3.c | 36 >> ++++++++++++++-------------- >> drivers/gpu/drm/i915/i915_oa_sklgt2.c | 36 >> ++++++++++++++-------------- >> drivers/gpu/drm/i915/i915_oa_sklgt3.c | 36 >> ++++++++++++++-------------- >> drivers/gpu/drm/i915/i915_oa_sklgt4.c | 36 >> ++++++++++++++-------------- >> drivers/gpu/drm/i915/i915_sysfs.c | 6 ++--- >> 11 files changed, 165 insertions(+), 165 deletions(-) >> > ~arvind