Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752487AbdHDM10 (ORCPT ); Fri, 4 Aug 2017 08:27:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:38183 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752430AbdHDM1Z (ORCPT ); Fri, 4 Aug 2017 08:27:25 -0400 Date: Fri, 4 Aug 2017 14:27:22 +0200 From: Joerg Roedel To: Baoquan He Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 11/13] iommu/amd: Don't copy GCR3 table root pointer Message-ID: <20170804122722.GW3431@suse.de> References: <1501587449-9817-1-git-send-email-bhe@redhat.com> <1501587449-9817-12-git-send-email-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501587449-9817-12-git-send-email-bhe@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 659 Lines: 14 On Tue, Aug 01, 2017 at 07:37:27PM +0800, Baoquan He wrote: > @@ -908,6 +911,14 @@ static int copy_device_table(void) > old_dev_tbl_cpy[devid].data[1] > = old_devtb[devid].data[1]; > __set_bit(dom_id, amd_iommu_pd_alloc_bitmap); > + /* If gcr3 table existed, mask it out */ > + if (old_devtb[devid].data[0] & DTE_FLAG_GV) { > + tmp = DTE_GCR3_VAL_B(~0ULL) << DTE_GCR3_SHIFT_B; > + tmp |= DTE_GCR3_VAL_C(~0ULL) << DTE_GCR3_SHIFT_C; > + old_dev_tbl_cpy[devid].data[1] &= ~tmp; > + tmp = DTE_GCR3_VAL_A(~0ULL) << DTE_GCR3_SHIFT_A; > + old_dev_tbl_cpy[devid].data[0] &= ~tmp; You also need to clear the DTE_FLAG_GV bit.