Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752986AbdHDNwv (ORCPT ); Fri, 4 Aug 2017 09:52:51 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:33184 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752506AbdHDNwt (ORCPT ); Fri, 4 Aug 2017 09:52:49 -0400 Reply-To: monstr@monstr.eu Subject: Re: [PATCH 1/2] watchdog: cadence_wdt: Enable access to module parameters To: Guenter Roeck , Michal Simek , linux-kernel@vger.kernel.org Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck References: <6c3cef5b847f315f5fc1eb891b040e33719e88c7.1501832354.git.michal.simek@xilinx.com> From: Michal Simek Message-ID: <54da75b5-aff9-84e8-1e3e-f311b358f77a@monstr.eu> Date: Fri, 4 Aug 2017 15:52:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="54ejLHervruK8DqiLj8HvATkLN9Lpx3om" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2779 Lines: 78 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --54ejLHervruK8DqiLj8HvATkLN9Lpx3om Content-Type: multipart/mixed; boundary="bR6s38jc9LO6GXnvhrVod1cpwkukBAR57"; protected-headers="v1" From: Michal Simek Reply-To: monstr@monstr.eu To: Guenter Roeck , Michal Simek , linux-kernel@vger.kernel.org Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck Message-ID: <54da75b5-aff9-84e8-1e3e-f311b358f77a@monstr.eu> Subject: Re: [PATCH 1/2] watchdog: cadence_wdt: Enable access to module parameters References: <6c3cef5b847f315f5fc1eb891b040e33719e88c7.1501832354.git.michal.simek@xilinx.com> In-Reply-To: --bR6s38jc9LO6GXnvhrVod1cpwkukBAR57 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 4.8.2017 15:45, Guenter Roeck wrote: > On 08/04/2017 12:39 AM, Michal Simek wrote: >> Give read access to module parameters to all and write access to root.= >> This change also improves driver error path testing. >> >> Signed-off-by: Michal Simek >> --- >> >> Please let me know what you think - I can use macros from stat.h if >> required >> >=20 > Seems to be quite pointless and misleading, since the values are only r= ead > at probe time. Am I missing something ? You can unbind device and bind that device again. If you want to use it or test with different parameters you need to have an access to these module parameters. For testing purpose if you setup for example timeout to 1000s which is more than CDNS_WDT_MAX_TIMEOUT probe will fail and you have better driver coverage. I see that a lot of watchdog drivers are using 0 there - means no sysfs access to these modules parameters. Some of them are using 0644 or 0444 that's why I want to know if there is any for example security reason to disable access to these parameters. Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs --bR6s38jc9LO6GXnvhrVod1cpwkukBAR57-- --54ejLHervruK8DqiLj8HvATkLN9Lpx3om Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAlmEfC4ACgkQykllyylKDCHasgCffdKwBYs+UEblkwvocSLeyVUO 6aQAn0X0qltdKNvwijyAN8YEAxjaE3ne =GFLi -----END PGP SIGNATURE----- --54ejLHervruK8DqiLj8HvATkLN9Lpx3om--