Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752537AbdHDOyP (ORCPT ); Fri, 4 Aug 2017 10:54:15 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:58977 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752273AbdHDOyN (ORCPT ); Fri, 4 Aug 2017 10:54:13 -0400 From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Cc: David Lechner , devicetree@vger.kernel.org, Mark Rutland , Kevin Hilman , Sekhar Nori , linux-kernel@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 3/6] dt-bindings: add binding for Sitronix ST7586 display panels Date: Fri, 04 Aug 2017 17:54:27 +0300 Message-ID: <2434051.fAH1OaXNrL@avalon> User-Agent: KMail/4.14.10 (Linux/4.9.34-gentoo; KDE/4.14.32; x86_64; ; ) In-Reply-To: <1501799630-1650-4-git-send-email-david@lechnology.com> References: <1501799630-1650-1-git-send-email-david@lechnology.com> <1501799630-1650-4-git-send-email-david@lechnology.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2103 Lines: 62 Hi David, Thank you for the patch. On Thursday 03 Aug 2017 17:33:47 David Lechner wrote: > This adds a new binding for Sitronix ST7586 display panels. > > Using lego as the vendor prefix in the compatible string because the display > panel I am working with is an integral part of the LEGO MINDSTORMS EV3. > > Signed-off-by: David Lechner > --- > .../bindings/display/sitronix,st7586.txt | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/sitronix,st7586.txt > > diff --git a/Documentation/devicetree/bindings/display/sitronix,st7586.txt > b/Documentation/devicetree/bindings/display/sitronix,st7586.txt new file > mode 100644 > index 0000000..dfb0b7b > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sitronix,st7586.txt > @@ -0,0 +1,26 @@ > +Sitronix ST7586 display panel > + > +Required properties: > +- compatible: "lego,ev3-lcd". > + > +The node for this driver must be a child node of a SPI controller, hence > +all mandatory properties described in ../spi/spi-bus.txt must be specified. > + > +Optional properties: > +- dc-gpios: D/C pin. The presence/absence of this GPIO determines > + the panel interface operation mode (IF[3:1] pins): > + - present: IF=011 4-wire 8-bit data serial interface > + - absent: IF=010 3-wire 9-bit data serial interface How does this work ? Do you have a single GPIO on your system connected to IF[1], with IF[3:2] hardwired to 01 ? > +- reset-gpios: Reset pin > +- power-supply: A regulator node for the supply voltage. > +- backlight: phandle of the backlight device attached to the panel > +- rotation: panel rotation in degrees counter clockwise (0,90,180,270) Please use the OF graph DT bindings (a.k.a. ports) to describe the connection between the panel and its source. > +Example: > + display@0{ > + compatible = "lego,ev3-lcd"; > + reg = <0>; > + spi-max-frequency = <10000000>; > + dc-gpios = <&gpio 43 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio 80 GPIO_ACTIVE_HIGH>; > + }; -- Regards, Laurent Pinchart