Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752565AbdHDPru (ORCPT ); Fri, 4 Aug 2017 11:47:50 -0400 Received: from ale.deltatee.com ([207.54.116.67]:44828 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752177AbdHDPrs (ORCPT ); Fri, 4 Aug 2017 11:47:48 -0400 To: Tomi Valkeinen , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-ntb@googlegroups.com, linux-crypto@vger.kernel.org, Jyri Sarha Cc: Arnd Bergmann , Greg Kroah-Hartman , Andy Shevchenko , =?UTF-8?Q?Horia_Geant=c4=83?= , Stephen Bates , David Airlie References: <20170803183018.5889-1-logang@deltatee.com> <20170803183018.5889-2-logang@deltatee.com> <2b41b02c-07e3-b927-f276-a29480f94285@ti.com> From: Logan Gunthorpe Message-ID: <15c19bbe-a178-5c60-530e-14229bfdc906@deltatee.com> Date: Fri, 4 Aug 2017 09:47:37 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <2b41b02c-07e3-b927-f276-a29480f94285@ti.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: airlied@linux.ie, sbates@raithlin.com, horia.geanta@nxp.com, andy.shevchenko@gmail.com, gregkh@linuxfoundation.org, arnd@arndb.de, jsarha@ti.com, linux-crypto@vger.kernel.org, linux-ntb@googlegroups.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, tomi.valkeinen@ti.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v6 1/7] drm/tilcdc: ensure nonatomic iowrite64 is not used X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 470 Lines: 15 On 04/08/17 07:03 AM, Tomi Valkeinen wrote: > I haven't really followed the discussion on this, but if the tilcdc's > use of iowrite64 causes (real) problems/complications elsewhere, I think > we could drop it. Well, that's up to you. The patch I submitted should still be correct though, and if arm ever gets a proper atomic iowrite64 implementation it would be good to use it. So in an annotative sense it's nice to keep the function call in there. Thanks, Logan