Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753028AbdHDQkl (ORCPT ); Fri, 4 Aug 2017 12:40:41 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:34552 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752433AbdHDQkk (ORCPT ); Fri, 4 Aug 2017 12:40:40 -0400 Date: Fri, 4 Aug 2017 09:40:34 -0700 From: Darren Hart To: Shuah Khan Cc: shuah@kernel.org, tglx@linutronix.de, mingo@redhat.com, peterz@infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] selftests: futex: fix run_tests target Message-ID: <20170804164034.GB21169@fury> References: <20170802223142.20282-1-shuahkh@osg.samsung.com> <20170803005222.GC27974@fury> <95d21b7c-be98-a8f5-fe67-ec4877d4a946@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <95d21b7c-be98-a8f5-fe67-ec4877d4a946@osg.samsung.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1508 Lines: 37 On Wed, Aug 02, 2017 at 07:06:39PM -0600, Shuah Khan wrote: > On 08/02/2017 06:52 PM, Darren Hart wrote: > > On Wed, Aug 02, 2017 at 04:31:42PM -0600, Shuah Khan wrote: > >> make -C tools/testing/selftests/futex/ run_tests doesn't run the tests. > >> Running run_tests target only when $(OUTPUT) is the $(PWD) is incorrect. > >> When $(OUTPUT) is empty, run_tests will not run. Fix it. > >> > >> Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT") > >> Signed-off-by: Shuah Khan > > > > So this indeed addresses the problem you reported. > > > > I'm curious about why this was changed like it was. I presume to avoid > > some issues with relative paths, like the ./run.sh and the "cd > > functional" within run.sh.... but I haven't been able to trigger that.> > > When you say $(OUTPUT) is empty - when does that occur? Because if it > > was in fact "" then the change below would attempt to execute /run.sh > > ... which is surely not what we want. > > This will not happen. At this stage, OUTPUT will not be empty. > > I didn't explain the condition correctly in my change log. When OUTPUT > isn't set (which is the usual case when test is run using: > > make -C tools/testing/selftests/futex run_tests > > lib.mk sets it to OUTPUT := $(shell pwd) > > So OUTPUT will be the current directory when run_tests are run. Thank you for the clarification. Reviewed-by: Darren Hart (VMware) -- Darren Hart VMware Open Source Technology Center