Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753075AbdHDQvY (ORCPT ); Fri, 4 Aug 2017 12:51:24 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:36702 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752177AbdHDQvX (ORCPT ); Fri, 4 Aug 2017 12:51:23 -0400 Subject: Re: [PATCH 4/4] axonram: Delete an unnecessary variable initialisation in axon_ram_probe() To: SF Markus Elfring , linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Jan Kara , Jens Axboe , Dan Williams , Michael Ellerman , Paul Mackerras Cc: kernel-janitors@vger.kernel.org, LKML References: <009fdef0-b2c9-5e98-d32d-14149aec92c5@users.sourceforge.net> From: Tyrel Datwyler Date: Fri, 4 Aug 2017 09:51:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17080416-8235-0000-0000-00000C0C8C0D X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007484; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000217; SDB=6.00897521; UDB=6.00449094; IPR=6.00677703; BA=6.00005509; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016535; XFM=3.00000015; UTC=2017-08-04 16:51:21 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17080416-8236-0000-0000-00003D1152FD Message-Id: <70701740-b1cd-d2b6-8334-6dcd727a53f3@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-04_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1708040258 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1037 Lines: 31 On 08/03/2017 12:17 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 3 Aug 2017 20:34:00 +0200 > > The local variable "rc" will eventually be set only to an error code. > Thus omit the explicit initialisation at the beginning. > > Signed-off-by: Markus Elfring > --- > arch/powerpc/sysdev/axonram.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/powerpc/sysdev/axonram.c b/arch/powerpc/sysdev/axonram.c > index 93cc902350db..5677f3371e30 100644 > --- a/arch/powerpc/sysdev/axonram.c > +++ b/arch/powerpc/sysdev/axonram.c > @@ -184,7 +184,6 @@ static int axon_ram_probe(struct platform_device *device) > static int axon_ram_bank_id = -1; > struct axon_ram_bank *bank; > struct resource resource; > - int rc = 0; You've completely removed the decleration of "rc" instead of removing the "= 0" initialization. I would expect a compilation test to have turned up an undeclared use error for "rc". -Tyrel > > axon_ram_bank_id++; >