Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751988AbdHDTfW (ORCPT ); Fri, 4 Aug 2017 15:35:22 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:25839 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751303AbdHDTfV (ORCPT ); Fri, 4 Aug 2017 15:35:21 -0400 Subject: Re: [PATCH 3/3] xen: remove not used trace functions To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Ingo Molnar , Steven Rostedt References: <20170804113613.12028-1-jgross@suse.com> <20170804113613.12028-4-jgross@suse.com> From: Boris Ostrovsky Message-ID: <3645b03d-7cda-46f1-3223-87b408b16193@oracle.com> Date: Fri, 4 Aug 2017 15:35:06 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170804113613.12028-4-jgross@suse.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1678 Lines: 55 On 08/04/2017 07:36 AM, Juergen Gross wrote: > There are some Xen specific trace functions defined in > include/trace/events/xen.h. Remove them. > > Signed-off-by: Juergen Gross (Again, adding Ingo and Steven) Reviewed-by: Boris Ostrovsky although I think "s/some Xen/some unused Xen/" in the commit message would make it clearer. > --- > include/trace/events/xen.h | 20 -------------------- > 1 file changed, 20 deletions(-) > > diff --git a/include/trace/events/xen.h b/include/trace/events/xen.h > index 677e8ac2bb81..1b4fed72f573 100644 > --- a/include/trace/events/xen.h > +++ b/include/trace/events/xen.h > @@ -248,16 +248,6 @@ TRACE_EVENT(xen_mmu_set_p4d, > (int)sizeof(p4dval_t) * 2, (unsigned long long)pgd_val(native_make_pgd(__entry->p4dval)), > (int)sizeof(p4dval_t) * 2, (unsigned long long)__entry->p4dval) > ); > - > -TRACE_EVENT(xen_mmu_pud_clear, > - TP_PROTO(pud_t *pudp), > - TP_ARGS(pudp), > - TP_STRUCT__entry( > - __field(pud_t *, pudp) > - ), > - TP_fast_assign(__entry->pudp = pudp), > - TP_printk("pudp %p", __entry->pudp) > - ); > #else > > TRACE_EVENT(xen_mmu_set_pud, > @@ -277,16 +267,6 @@ TRACE_EVENT(xen_mmu_set_pud, > > #endif > > -TRACE_EVENT(xen_mmu_pgd_clear, > - TP_PROTO(pgd_t *pgdp), > - TP_ARGS(pgdp), > - TP_STRUCT__entry( > - __field(pgd_t *, pgdp) > - ), > - TP_fast_assign(__entry->pgdp = pgdp), > - TP_printk("pgdp %p", __entry->pgdp) > - ); > - > DECLARE_EVENT_CLASS(xen_mmu_ptep_modify_prot, > TP_PROTO(struct mm_struct *mm, unsigned long addr, > pte_t *ptep, pte_t pteval),