Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752299AbdHDUsi (ORCPT ); Fri, 4 Aug 2017 16:48:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46036 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751870AbdHDUsg (ORCPT ); Fri, 4 Aug 2017 16:48:36 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6BB5E80469 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=rkrcmar@redhat.com Date: Fri, 4 Aug 2017 22:48:27 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, David Hildenbrand Subject: Re: [PATCH RFC 1/2] KVM: x86: generalize guest_cpuid_has_ helpers Message-ID: <20170804204827.GB2119@potion> References: <20170802204147.3586-1-rkrcmar@redhat.com> <20170802204147.3586-2-rkrcmar@redhat.com> <3924d878-c8f1-06f7-1051-19864708211e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3924d878-c8f1-06f7-1051-19864708211e@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 04 Aug 2017 20:48:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 412 Lines: 11 2017-08-04 17:40+0200, Paolo Bonzini: > Wow, I didn't expect the compiler to be able to inline all of this and > even do BUILD_BUG_ON()s on array lookups. Maybe change inline to > __always_inline just to be safe? > > If anybody complains we can make it just a BUG. Good point, i386 wanted to have non-inlined guest_cpuid_get_register(), but I hope that __always_inline is going to be enough for all. Thanks.