Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752403AbdHDVGz (ORCPT ); Fri, 4 Aug 2017 17:06:55 -0400 Received: from g4t3426.houston.hpe.com ([15.241.140.75]:47444 "EHLO g4t3426.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751323AbdHDVGx (ORCPT ); Fri, 4 Aug 2017 17:06:53 -0400 From: "Kani, Toshimitsu" To: "bp@alien8.de" CC: "linux-edac@vger.kernel.org" , "lenb@kernel.org" , "mchehab@kernel.org" , "tony.luck@intel.com" , "linux-kernel@vger.kernel.org" , "rjw@rjwysocki.net" , "linux-acpi@vger.kernel.org" Subject: Re: [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac Thread-Topic: [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac Thread-Index: AQHTDKTxRHS2u4QizkezeCTvUOrq1qJz3uKAgADQOoA= Date: Fri, 4 Aug 2017 21:06:27 +0000 Message-ID: <1501880213.2042.119.camel@hpe.com> References: <20170803215753.30553-1-toshi.kani@hpe.com> <20170803215753.30553-6-toshi.kani@hpe.com> <20170804083137.GB15617@nazgul.tnic> In-Reply-To: <20170804083137.GB15617@nazgul.tnic> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-originating-ip: [15.219.147.8] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DF4PR84MB0185;6:i325/Wl34IygMjoq+hEV/WUSEySlVO8bkpSzpWs8l+wKRqcgj5diyxNrYY9yCzcqAi/97nm7rOjWreBLNAuIP3rgm8yTtTwb7vvrli11ryUcIYkQY1lCPM8wWxoKEwZm5cUWUSr+Jvq/1UHSxtzOLkGLGftUCF7mDTjui0ENsgpaKrgvEjyIYRdzl2Cu7paAuOpswJ3y5UX9fkuCOzObZ5qLs/t1zifF6YK/h8nK3B1WPwrULtMHVM7UfWsDz1+RyenU/yQaT/B0pNCxJOSSJj/JD9WdgCtj8fBP+mpkzWXuZePu2zTo2onB3IFdSZJOhsNwjy5S10zOH/BFvuTd8Q==;5:kHTYA4OTIyBZMBrw139RpfCZjy1RaWqUXUr43ln9npwRxm7cYIHupOWu9I+h2iSlGNSxkHKOv685DYFvmYcrzlb4L5XivKJgyOZmvsEV5x1iN32T3aYWAWmryAzcQIke0jlTEKKldTnHMiWr0fjgsQ==;24:+XoVKubMgG9t6qJvPLV1Vkvx7nOLnNI9y4q6kQ1FmWJgIsjFHTiGvKyNVHvUUn+rqNGAKyd7urX9+LgVrXvB6OU7cLRaDKzaWmOEnczI/0A=;7:4QQJauxcUaT/gBE0uTRLnCmRvyFnQHbszuJHiPQtjqdCnvdMymYnJ+gk53iJo3dEfOCf7Wqstry8YtVN+KvnvbwgFovf3rJhjcJkbLa1wEIrnpdejlUAXInZN30Jpu57Ygt0vdwSkgMWFhquYZP9qxPnGj9GauWl58ncKMppjOw5uTbbrbcikNc+cvVw305l8ibhoO6lePB2zOpxsAE4raI3yu1aJEQT5O4Gu2C9Fhc= x-ms-office365-filtering-correlation-id: 099b1aeb-62b3-4831-00b5-08d4db7cabf0 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DF4PR84MB0185; x-ms-traffictypediagnostic: DF4PR84MB0185: x-exchange-antispam-report-test: UriScan:(20558992708506); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123558100)(20161123564025)(20161123562025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DF4PR84MB0185;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DF4PR84MB0185; x-forefront-prvs: 0389EDA07F x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(39840400002)(39410400002)(39850400002)(39400400002)(39450400003)(24454002)(377424004)(189002)(199003)(36756003)(5640700003)(106356001)(6436002)(6512007)(54906002)(6246003)(81166006)(81156014)(1730700003)(8676002)(5660300001)(8936002)(33646002)(305945005)(3660700001)(7736002)(103116003)(25786009)(2351001)(3280700002)(2501003)(2906002)(105586002)(478600001)(189998001)(6916009)(229853002)(86362001)(14454004)(6506006)(101416001)(66066001)(97736004)(2950100002)(4326008)(68736007)(2900100001)(76176999)(54356999)(38730400002)(53936002)(102836003)(3846002)(110136004)(50986999)(6116002)(77096006)(6486002);DIR:OUT;SFP:1102;SCL:1;SRVR:DF4PR84MB0185;H:DF4PR84MB0187.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <3CD443D9A59481468BD0924D6C4B17D0@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2017 21:06:27.1580 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR84MB0185 X-OriginatorOrg: hpe.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v74L71Gv004455 Content-Length: 1151 Lines: 26 On Fri, 2017-08-04 at 10:31 +0200, Borislav Petkov wrote: > On Thu, Aug 03, 2017 at 03:57:51PM -0600, Toshi Kani wrote: > > The ghes_edac driver was introduced in 2013 [1], but it has not > > been enabled by any distro yet.  This driver obtains error info > > from firmware interfaces, which are not properly implemented on > > many platforms, as the driver always emits the messages below: > > > >  This EDAC driver relies on BIOS to enumerate memory and get error > > reports.  Unfortunately, not all BIOSes reflect the memory layout > > correctly  So, the end result of using this driver varies from > > vendor to vendor  If you find incorrect reports, please contact > > your hardware vendor to correct its BIOS. > > > > To get out from this situation, add a platform check to selectively > > enable the driver on the platforms that are known to have proper > > firmware implementation.  Platform vendors can add their platforms > > to the list when they support ghes_edac. > > > > "ghes_edac.any_oem=1" skips this platform check. > > There's that non-generic OEM thing again. NAK! How about "ghes_edac.any_platform"? Thanks, -Toshi