Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751984AbdHEPPs (ORCPT ); Sat, 5 Aug 2017 11:15:48 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:38829 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751262AbdHEPPq (ORCPT ); Sat, 5 Aug 2017 11:15:46 -0400 Date: Sun, 6 Aug 2017 00:15:41 +0900 From: Stafford Horne To: Shuah Khan Cc: dvhart@infradead.org, shuah@kernel.org, tglx@linutronix.de, mingo@redhat.com, peterz@infradead.org, naresh.kamboju@linaro.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] selftests: futex: convert test to use ksft TAP13 framework Message-ID: <20170805151541.GB3031@lianli.shorne-pla.net> References: <20170805004650.31046-1-shuahkh@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170805004650.31046-1-shuahkh@osg.samsung.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1148 Lines: 43 On Fri, Aug 04, 2017 at 06:46:50PM -0600, Shuah Khan wrote: > Convert test to use ksft TAP13 framework. > --- a/tools/testing/selftests/futex/include/logging.h > +++ b/tools/testing/selftests/futex/include/logging.h > @@ -109,22 +109,20 @@ void log_verbosity(int level) > */ > void print_result(const char *test_name, int ret) > { > - const char *result = "Unknown return code"; > - > switch (ret) { > case RET_PASS: > - ksft_inc_pass_cnt(); > - result = PASS; > - break; > + ksft_test_result_pass("%s\n", test_name); > + ksft_print_cnts(); > + return; > case RET_ERROR: > - result = ERROR; > - break; > + ksft_test_result_error("%s\n", test_name); > + ksft_print_cnts(); > + return; This looks ok to me, but this function `ksft_test_result_error` was added in another patch you just sent, it was a bit hard to review. If you need to make and updates, could you please send a series next? -Stafford > case RET_FAIL: > - ksft_inc_fail_cnt(); > - result = FAIL; > - break; > + ksft_test_result_fail("%s\n", test_name); > + ksft_print_cnts(); > + return; > } > - printf("selftests: %s [%s]\n", test_name, result);