Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752660AbdHEU6G (ORCPT ); Sat, 5 Aug 2017 16:58:06 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:45352 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434AbdHEU6E (ORCPT ); Sat, 5 Aug 2017 16:58:04 -0400 Date: Sat, 5 Aug 2017 13:57:53 -0700 From: Darren Hart To: "Rafael J. Wysocki" Cc: Mario Limonciello , AceLan Kao , linux-pm@vger.kernel.org, LKML , platform-driver-x86@vger.kernel.org, Len Brown , Srinivas Pandruvada , Andy Shevchenko Subject: Re: [PATCH] intel-vbtn: match power button on press rather than release Message-ID: <20170805205753.GA1277@fury> References: <1501866006-24811-1-git-send-email-mario.limonciello@dell.com> <20170804172953.GC21169@fury> <11471111.T3jHVeqpMT@aspire.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11471111.T3jHVeqpMT@aspire.rjw.lan> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1709 Lines: 44 On Sat, Aug 05, 2017 at 01:30:20AM +0200, Rafael Wysocki wrote: > On Friday, August 4, 2017 7:29:53 PM CEST Darren Hart wrote: > > On Fri, Aug 04, 2017 at 12:00:06PM -0500, Mario Limonciello wrote: > > > This fixes a problem where the system gets stuck in a loop > > > unable to wakeup via power button in s2idle. > > > > > > The problem happens because: > > > - press power button: > > > - system emits 0xc0 (power press), event ignored > > > - system emits 0xc1 (power release), event processed, > > > emited as KEY_POWER > > > - set wakeup_mode to true > > > - system goes to s2idle > > > - press power button > > > - system emits 0xc0 (power press), wakeup_mode is true, > > > system wakes > > > - system emits 0xc1 (power release), event processed, > > > emited as KEY_POWER > > > - system goes to s2idle again > > > > > > To avoid this situation, process the presses (which matches what > > > intel-hid does too). > > > > > > Verified on an Dell XPS 9365 > > > > > > Signed-off-by: Mario Limonciello > > > > This looks good to me - responding to the release is non-intuitive IMHO > > anyway. I'd like to see agreement from AceLan, but this should go into > > the 4.13 rc cycle (at rc3 currently). > > Yes, it should, and I'm not sure if the original author's opinion matters here. > > The patch makes sense to everyone involved and fixes an annoying issue, so > I don't see any real arguments against applying it. > > Please feel free to add my ACK to it if that helps. I always try to give those in MAINTAINERS a chance to respond, but I will queue this up to fixes now. -- Darren Hart VMware Open Source Technology Center