Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751358AbdHFFmY (ORCPT ); Sun, 6 Aug 2017 01:42:24 -0400 Received: from home.keithp.com ([63.227.221.253]:49852 "EHLO elaine.keithp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751179AbdHFFmX (ORCPT ); Sun, 6 Aug 2017 01:42:23 -0400 From: "Keith Packard" To: Michel =?utf-8?Q?D=C3=A4nzer?= , Dave Airlie , Daniel Vetter Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls [v2] In-Reply-To: <55be11c9-d1e0-d6f9-e497-512e9926eff4@daenzer.net> References: <20170705221013.27940-1-keithp@keithp.com> <20170801050306.24423-1-keithp@keithp.com> <20170801050306.24423-4-keithp@keithp.com> <55be11c9-d1e0-d6f9-e497-512e9926eff4@daenzer.net> Date: Sat, 05 Aug 2017 23:42:57 -0400 Message-ID: <87mv7dfjjy.fsf@keithp.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2112 Lines: 61 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Michel D=C3=A4nzer writes: > [...] > >> +#define DRM_CRTC_SEQUENCE_NEXT_ON_MISS 0x00000002 /* Use next sequence= if we've missed */ > > Do you have userspace making use of DRM_CRTC_SEQUENCE_NEXT_ON_MISS? If > not, drop it. I added this so that the new ioctl would be compatible with the old ioctl; do you think that's unnecessary? > >> +#define DRM_CRTC_SEQUENCE_FIRST_PIXEL_OUT 0x00000004 /* Signal when fir= st pixel is displayed */ > > I thought there was consensus that this flag is pointless. I just wrote a note to Daniel about this; I think it is useful in that applications could specify that they actually want the event delivered at first pixel out in accordance with the Vulkan spec, even if we can't do that (yet). I definitely agree that requiring the bit be set is ridiculous and should be removed. Two choices 1) Remove the code which checks whether the flag is set. Make Vulkan set the flag signaling what it wants. Plan on doing the actual driver work if we find that it's necessary. 2) Remove the flag entirely. Any preference? =2D-=20 =2Dkeith --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAlmGkEEACgkQ2yIaaQAA ABF6AA//agU82Al1zE+ey0Nd2Ze3BNmsV7lJOZ/qaKqaFHa+ZHuaNfpZJ89IneMe FgPP3KKoCMpg4G8+2hx3mwGPX4/l1I2wZ55IuO3vnm2G1ujh3pmRX1eP1B+Cl2pX /OpYNF4KDov06k/DPBGv+D6GY0zALiPwJAczX4rZxe6b6V4v6JlUefDah3NrOKad 4dBXGOA6G2X1BystHaaV3C2mCvkJVCDB1VAVn4PjdTtXEEJza+Cxa55AtH/CHIEB xhi9C0rT4LvspAhMXl3+shaYgHeQYFZkBSOotAQ78IWimCCpimE/HwJC9rRtN0kk Yi1lNUrMyYaI7XjZOb+NMT453BHcaiCiMqd2iE6ngog5mxyudgUWXPx4RHXl7rFK IkbMLt7FaQcQCXs4Qp9bWokiOuy47x5liZXaShLtXqTAq+k4LZxqfReSgiGb1r8x 3//CHhKW4mcqsWSY3YF3s+ioz2J1Vc+z7Xjb3bUDEvmgRdf3GxR6XTilJyqsE5Kt OP98lkvxCXFCpVAlOkVYlVOXuY7ioZrzPhax2ptoxX+Jv9qmjCrPhDA154Uti7Db iZjLlE+TMJ2x+J4oEkDEsaTQ0idKonrU7qhL+E3shzfI+H4A7ltbgb4FHG2hxdP/ Q12AUV3KoNbhmd0jirTnS/8A5dtRE3Zb454PWBsA74FK1CN3uWM= =KTdr -----END PGP SIGNATURE----- --=-=-=--