Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751386AbdHFN4A (ORCPT ); Sun, 6 Aug 2017 09:56:00 -0400 Received: from gloria.sntech.de ([95.129.55.99]:38368 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277AbdHFNz7 (ORCPT ); Sun, 6 Aug 2017 09:55:59 -0400 From: Heiko Stuebner To: Jacob Chen Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 4/5] arm64: dts: rockchip: add rk3399 mipi nodes Date: Sun, 06 Aug 2017 15:55:50 +0200 Message-ID: <1762581.zRg8RSfhNk@phil> User-Agent: KMail/5.2.3 (Linux/4.9.0-2-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <1500301019-9960-5-git-send-email-jacob-chen@iotwrt.com> References: <1500301019-9960-1-git-send-email-jacob-chen@iotwrt.com> <1500301019-9960-5-git-send-email-jacob-chen@iotwrt.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1853 Lines: 70 Am Montag, 17. Juli 2017, 22:16:58 CEST schrieb Jacob Chen: > Add an mipi node, and also add mipi endpoints to vopb and vopl > output port nodes. > > Signed-off-by: Jacob Chen > --- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 44 ++++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index c0371af..5c5c9d9 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -1475,6 +1475,11 @@ > #address-cells = <1>; > #size-cells = <0>; > > + vopl_out_mipi: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&mipi_in_vopl>; > + }; > + > vopl_out_edp: endpoint@1 { > reg = <1>; > remote-endpoint = <&edp_in_vopl>; > @@ -1516,6 +1521,11 @@ > remote-endpoint = <&edp_in_vopb>; > }; > > + vopb_out_mipi: endpoint@1 { > + reg = <1>; > + remote-endpoint = <&mipi_in_vopb>; > + }; > + > }; > }; > > @@ -1531,6 +1541,40 @@ > status = "disabled"; > }; > > + mipi_dsi: mipi@ff960000 { > + compatible = "rockchip,rk3399-mipi-dsi", "snps,dw-mipi-dsi"; > + reg = <0x0 0xff960000 0x0 0x8000>; > + interrupts = ; > + clocks = <&cru SCLK_MIPIDPHY_REF>, <&cru PCLK_MIPI_DSI0>, > + <&cru SCLK_DPHY_TX0_CFG>; > + clock-names = "ref", "pclk", "phy_cfg"; > + power-domains = <&power RK3399_PD_VIO>; > + rockchip,grf = <&grf>; > + #address-cells = <1>; > + #size-cells = <0>; I've dropped these, as the ports node does not need a regs property. Similar to edp and hdmi. > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; dropped this reg as well - see above and applied the rest for 4.14 Thanks Heiko