Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751424AbdHFOA2 (ORCPT ); Sun, 6 Aug 2017 10:00:28 -0400 Received: from mout.web.de ([212.227.17.11]:64916 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751256AbdHFOA0 (ORCPT ); Sun, 6 Aug 2017 10:00:26 -0400 Subject: Re: [PATCH v2 00/17] IB/mlx: Fine-tuning for several function implementations From: SF Markus Elfring To: Doug Ledford , Hal Rosenstock , Leon Romanovsky , Majd Dibbiny , Matan Barak , Sean Hefty , Yishai Hadas , linux-rdma@vger.kernel.org Cc: LKML , kernel-janitors@vger.kernel.org References: <1935365a-bd7c-461e-6a84-0c5d3a501fff@users.sourceforge.net> <1492720654.3041.16.camel@redhat.com> Message-ID: <617e30ff-2705-b053-ee28-ed9385037580@users.sourceforge.net> Date: Sun, 6 Aug 2017 16:00:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:ac03btH/ietHXSN2wiSt+APgDYfx86kNeNsbi7ZnApSiMf3gTCO Zz4joUH0JETbiTJXPDY9HQrYtS8anonZd3W8I9IGEgCbcFeRi/YHAqfnCf3GD2yLMxTLYjd k30bvHYSeLxhzkg/GwmtAHeM5j2fco/phamcgptodJ0bXr6fI2F5cSUtpucI4PDuuETqYmz 5Q1DeuFDFXehesYEfF53g== X-UI-Out-Filterresults: notjunk:1;V01:K0:jRJGckmx6oc=:tliiuQd46juLzx0cvD0rgr 2I+9iucSTpJ0r14/TWcJfmCLiYhWTkCsTUDoER2GqZFj/WExiK2FEngHK/NmVvLO700sn516r ds8l38AdmdDVdt0xu8NUBX9rofUN6yK/+zC/irmmw0ZWtI+4uJGomr8se2oW7sC2Yf5sQxM/s Tj4JLAOUM1wmX8/05PFJKRfkg1publfH/t84G6ws4y7QKjdN5EiPY/VCsEMRqb1O2b+AyLda8 5Pn8iqo2xVHZTl3cnFd5MQ48ofQlGVSLxh5TWA/456+CEogTQCBm1Eorur12GpsVNml3BswhJ sS51QyRPKjnyXl0VDFjCTeALBixcLntvyTxixopsZBy+MDDHWD8QDnpKVPVoXQuzJJrMOV/9F NgzNFktNxKuNUwXJNGnCUrCx4D5dHX4do8TPPGnyooQBkjw8caqIBhJP9ny3FzWvyAkG+J5yC odNsVZ9uEAsYCyGi9+QSO7uuPAkNpvEFJcc+GLRTFJJD5mJnZL/pqEWkrYX+0Wuf0dSDFd1M5 hmE0RB3DYHclxZFYA9MlZ3/9xYUL141+b1qAAFO4GYeSwOBFI66QVmQ7aWKwpSbQN5xFi6YXa OuShb0nWtMWCkR7h93KF9NONOwarYqO4nJIjeFg/03tHxzhIRYbYhomIquk8sHFp6NWkBBB7k 57PpZcf58qlezxczXrdP/EU+VFtS7MuzjDVUmviv5qsfLzERD+C9CLK+9/2Ka1e42GzGG+Pe9 v+VTFKgnNBXIs7Po8dJgVgCV+2xqsWoHsGAcKh/kA0ot2PgsDt5RzypvLhBkqeu6NM+dtkb0+ gpohNhW5Dm89IfXc5p+/wB13ATO4ku+is3dl5nCjT99Lw8K0nU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1698 Lines: 40 > Date: Fri, 21 Apr 2017 19:56:54 +0200 > > Several update suggestions were taken into account > from static source code analysis. > > Markus Elfring (17): > Use kcalloc() in mlx4_ib_alloc_pv_bufs() > Use kmalloc_array() in six functions > Improve size determinations in six functions > Fix a typo in a comment line > Delete four unnecessary return statements > Delete an unnecessary check before kfree() in free_pv_object() > Move an assignment out of a check in forward_trap() > Enclose 46 expressions for sizeof by parentheses > Split a condition check in six functions > Delete an unnecessary variable in __mlx4_ib_query_gid() > Delete an unnecessary variable initialisation in mlx4_ib_add() > Delete an unnecessary variable assignment in mlx4_ib_add() > Delete an error message for a failed memory allocation in mlx4_ib_add() > Delete unnecessary braces in mlx4_ib_add() > Delete unwanted spaces behind usages of the sizeof operator > Add spaces for better code readability > Less function calls in create_kernel_qp() after error detection > --- > > v2: > Changes were rebased on source files from Linux next-20170421. > Some of them were recombined as requested by Doug Ledford. > > drivers/infiniband/hw/mlx4/mad.c | 72 ++++++++-------- > drivers/infiniband/hw/mlx4/main.c | 164 ++++++++++++++++++++---------------- > drivers/infiniband/hw/mlx4/qp.c | 173 +++++++++++++++++++------------------- > drivers/infiniband/hw/mlx5/qp.c | 66 ++++++++++----- > drivers/infiniband/hw/mlx5/srq.c | 5 +- > 5 files changed, 261 insertions(+), 219 deletions(-) Will the clarification be continued for the shown change possibilities? Regards, Markus