Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751425AbdHFOfU (ORCPT ); Sun, 6 Aug 2017 10:35:20 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:59647 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751282AbdHFOfS (ORCPT ); Sun, 6 Aug 2017 10:35:18 -0400 Subject: Re: [PATCH 18/18] i2c-cht-wc: Add device-properties for fusb302 integration To: Hans de Goede , Darren Hart , Andy Shevchenko , Wolfram Sang , Sebastian Reichel , Greg Kroah-Hartman , Heikki Krogerus Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Liam Breck , Tony Lindgren , linux-pm@vger.kernel.org, devel@driverdev.osuosl.org References: <20170806123555.5124-1-hdegoede@redhat.com> <20170806123555.5124-19-hdegoede@redhat.com> From: Guenter Roeck Message-ID: <9ba933c6-daae-f30d-2c83-e9c2b756d27f@roeck-us.net> Date: Sun, 6 Aug 2017 07:35:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170806123555.5124-19-hdegoede@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2075 Lines: 49 On 08/06/2017 05:35 AM, Hans de Goede wrote: > Add device-properties to make the bq24292i controller connected to > the bus get its input-current-limit from the fusb302 Type-C port > controller which is used on boards with the cht-wc PMIC. > > Signed-off-by: Hans de Goede > --- > drivers/i2c/busses/Kconfig | 5 +++++ > drivers/i2c/busses/i2c-cht-wc.c | 5 ++++- > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index f20b1f84013a..6de21a81b00b 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -197,6 +197,11 @@ config I2C_CHT_WC > SMBus controller found in the Intel Cherry Trail Whiskey Cove PMIC > found on some Intel Cherry Trail systems. > > + Note this controller is hooked up to a TI bq24292i charger-IC, > + combined with a FUSB302 Type-C port-controller as such it is advised > + to also select CONFIG_CHARGER_BQ24190=m and CONFIG_TYPEC_FUSB302=m > + (the fusb302 driver currently is in drivers/staging). > + Just wondering - is this always the case ? What if someone builds a system with different charger and port controller ICs ? > config I2C_NFORCE2 > tristate "Nvidia nForce2, nForce3 and nForce4" > depends on PCI > diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c > index ccf0785bcb75..08229fb12615 100644 > --- a/drivers/i2c/busses/i2c-cht-wc.c > +++ b/drivers/i2c/busses/i2c-cht-wc.c > @@ -211,8 +211,11 @@ static const struct irq_chip cht_wc_i2c_irq_chip = { > .name = "cht_wc_ext_chrg_irq_chip", > }; > > +static const char * const bq24190_suppliers[] = { "fusb302-typec-source" }; > + > static const struct property_entry bq24190_props[] = { > - PROPERTY_ENTRY_STRING("extcon-name", "cht_wcove_pwrsrc"), > + PROPERTY_ENTRY_STRING_ARRAY("supplied-from", bq24190_suppliers), > + PROPERTY_ENTRY_BOOL("input-current-limit-from-supplier"), > PROPERTY_ENTRY_BOOL("omit-battery-class"), > PROPERTY_ENTRY_BOOL("disable-reset"), > { } >