Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751415AbdHFO7B (ORCPT ); Sun, 6 Aug 2017 10:59:01 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:56178 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751323AbdHFO67 (ORCPT ); Sun, 6 Aug 2017 10:58:59 -0400 Subject: Re: [PATCH 08/18] staging: typec: fusb302: Add support for USB2 charger detection through extcon To: Hans de Goede , Darren Hart , Andy Shevchenko , Wolfram Sang , Sebastian Reichel , Greg Kroah-Hartman , Heikki Krogerus Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Liam Breck , Tony Lindgren , linux-pm@vger.kernel.org, devel@driverdev.osuosl.org References: <20170806123555.5124-1-hdegoede@redhat.com> <20170806123555.5124-9-hdegoede@redhat.com> <9de0a2f3-7316-5a7d-d715-29e83a278844@roeck-us.net> <60616f13-207e-f998-7151-ad670c876166@redhat.com> From: Guenter Roeck Message-ID: Date: Sun, 6 Aug 2017 07:58:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <60616f13-207e-f998-7151-ad670c876166@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4085 Lines: 93 On 08/06/2017 07:36 AM, Hans de Goede wrote: > Hi, > > On 06-08-17 16:22, Guenter Roeck wrote: >> On 08/06/2017 05:35 AM, Hans de Goede wrote: >>> The fusb302 port-controller relies on an external device doing USB2 >>> charger-type detection. >>> >>> The Intel Whiskey Cove PMIC with which the fusb302 is combined on some >>> X86/ACPI platforms already has a charger-type detection driver which >>> uses extcon to communicate the detected charger-type. >>> >>> This commit uses the tcpm_get_usb2_current_limit_extcon helper to enable >>> USB2 charger detection on these systems. Note that the "fcs,extcon-name" >>> property name is only for kernel internal use by X86/ACPI platform code >>> and as such is NOT documented in the devicetree bindings. >>> >>> Signed-off-by: Hans de Goede >>> --- >>> drivers/staging/typec/fusb302/fusb302.c | 16 ++++++++++++++++ >>> 1 file changed, 16 insertions(+) >>> >>> diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/fusb302.c >>> index be454b5ff6c7..1d8c9b66df2f 100644 >>> --- a/drivers/staging/typec/fusb302/fusb302.c >>> +++ b/drivers/staging/typec/fusb302/fusb302.c >>> @@ -1201,6 +1201,8 @@ static void init_tcpc_dev(struct tcpc_dev *fusb302_tcpc_dev) >>> { >>> fusb302_tcpc_dev->init = tcpm_init; >>> fusb302_tcpc_dev->get_vbus = tcpm_get_vbus; >>> + fusb302_tcpc_dev->get_usb2_current_limit = >>> + tcpm_get_usb2_current_limit_extcon; >>> fusb302_tcpc_dev->set_cc = tcpm_set_cc; >>> fusb302_tcpc_dev->get_cc = tcpm_get_cc; >>> fusb302_tcpc_dev->set_polarity = tcpm_set_polarity; >>> @@ -1685,6 +1687,7 @@ static int fusb302_probe(struct i2c_client *client, >>> struct fusb302_chip *chip; >>> struct i2c_adapter *adapter; >>> struct device *dev = &client->dev; >>> + const char *name; >>> int ret = 0; >>> u32 val; >>> @@ -1717,6 +1720,19 @@ static int fusb302_probe(struct i2c_client *client, >>> if (device_property_read_u32(dev, "fcs,operating-snk-mw", &val) == 0) >>> chip->tcpc_config.operating_snk_mw = val; >>> + /* >>> + * Devicetree platforms should get extcon via phandle (not yet >>> + * supported). On ACPI platforms, we get the name from a device prop. >>> + * This device prop is for kernel internal use only and is expected >>> + * to be set by the platform code which also registers the i2c client >>> + * for the fusb302. >>> + */ >>> + if (device_property_read_string(dev, "fcs,extcon-name", &name) == 0) { >> >> Those new devicetree properties need to be documented and approved by dt maintainers. > > As indicated by the comment, this property should not be used in the devicetree > case, notice this is a device-property and not an of property and since it is > not intended to be used with devicetree at all (in devicetree a phandle rather > then a name would be used), it has no place under Documentation/devicetree at all. > Ok. I thought device properties were supposed to unify dt and non-dt situations, but apparently not. Oh well :-(. > Also there is no current binding documentation for the "fcs,fusb302" compatible > and the weird "fcs,int_n" gpio which really is an irq which it already uses. > Yes, one of those TODO items for moving the code out of staging. "fcs," should possibly be "fusb302,", and int_n _is_ weird. > >> >>> + chip->tcpc_dev.usb2_extcon = extcon_get_extcon_dev(name); >>> + if (!chip->tcpc_dev.usb2_extcon) >> >> extcon_get_extcon_dev() can also return an ERR_PTR. >> >> As before, I am not really happy typing this into tcpm via tcpc_dev. >> Until we have a better solution, I would prefer for that code to stay with the fusb302 >> code. > > Ok, I tried to make this all re-usable since I think other port-controller drivers > will need something similar, but I can kill the entire tcpm-helpers.c file in v2 > and then put everything in fusb302.c. I take it that that is what you want ? > Yes, please. Also, please copy Yueyao Zhu for the fusb302 changes in v2. Thanks, Guenter