Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751371AbdHFQ3L (ORCPT ); Sun, 6 Aug 2017 12:29:11 -0400 Received: from mail-qk0-f194.google.com ([209.85.220.194]:34733 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751300AbdHFQ3J (ORCPT ); Sun, 6 Aug 2017 12:29:09 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170806123555.5124-1-hdegoede@redhat.com> <20170806123555.5124-19-hdegoede@redhat.com> <9ba933c6-daae-f30d-2c83-e9c2b756d27f@roeck-us.net> From: Andy Shevchenko Date: Sun, 6 Aug 2017 19:29:08 +0300 Message-ID: Subject: Re: [PATCH 18/18] i2c-cht-wc: Add device-properties for fusb302 integration To: Hans de Goede Cc: Guenter Roeck , Darren Hart , Andy Shevchenko , Wolfram Sang , Sebastian Reichel , Greg Kroah-Hartman , Heikki Krogerus , Platform Driver , "linux-kernel@vger.kernel.org" , linux-i2c , Liam Breck , Tony Lindgren , "linux-pm@vger.kernel.org" , devel@driverdev.osuosl.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1108 Lines: 27 On Sun, Aug 6, 2017 at 6:05 PM, Hans de Goede wrote: > On 06-08-17 16:35, Guenter Roeck wrote: >> On 08/06/2017 05:35 AM, Hans de Goede wrote: > FWIW all DSTDs I've seen are all copy and paste and all declare a INT33FE > ACPI > device with identical i2c client addresses which strongly suggests the > use of the same combo. Note that on most devices this part of the DSTD is > not active (_STA returns 0) because they actually use a different config. Which is quite likely just blindly copied from a reference BIOS code. (Reminds me that bug with GPIO pin setting for interrupt as output only) > The only extra safe-guard I can come up with is a DMI string check, but that > is sub-optimal since the DMI strings on these devices contain useful values > as "Default String" still we could add it as an extra check. ...and in worst cases CPU model ID. > Since I had the same concern I've done a web search and I've been unable > to find any other devices which seem to use a Whiskey Cove PMIC, but that > does not mean that there aren't any. -- With Best Regards, Andy Shevchenko