Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751405AbdHFVHS (ORCPT ); Sun, 6 Aug 2017 17:07:18 -0400 Received: from mail.kapsi.fi ([91.232.154.25]:48658 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751342AbdHFVHR (ORCPT ); Sun, 6 Aug 2017 17:07:17 -0400 Date: Sun, 6 Aug 2017 23:42:24 +0300 From: Mikko Rapeli To: James Bottomley Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH v06 04/36] uapi scsi/scsi_netlink_fc.h: use __u16, __u32 and __u64 from linux/types.h Message-ID: <20170806204224.GE28459@lakka.kapsi.fi> References: <20170806164428.2273-1-mikko.rapeli@iki.fi> <20170806164428.2273-5-mikko.rapeli@iki.fi> <1502043773.2673.9.camel@HansenPartnership.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1502043773.2673.9.camel@HansenPartnership.com> X-SA-Exim-Connect-IP: 2001:1bc8:1004::1 X-SA-Exim-Mail-From: mcfrisk@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 874 Lines: 27 Hi, On Sun, Aug 06, 2017 at 11:22:53AM -0700, James Bottomley wrote: > On Sun, 2017-08-06 at 18:43 +0200, Mikko Rapeli wrote: > > Fixes userspace compilation errors like: > > > > scsi/scsi_netlink_fc.h:60:2: error: expected specifier-qualifier-list > > before ‘uint64_t’ > > Rather than patching the kernel, why not #include in your > userspace programme? The userspace program is actually a test which checks that uapi headers compile alone because several headers are not compiling at all and/or require special tricks. The test is available here: http://marc.info/?l=linux-kernel&m=150203944104544&w=2 I have tried that approach before but then: https://lkml.org/lkml/2015/6/1/160 For some subsystems like fuse the above message was not enough and they are including stdint.h in userspace. What shall we do with this old scsi header file? -Mikko