Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751669AbdHGBh0 (ORCPT <rfc822;w@1wt.eu>);
        Sun, 6 Aug 2017 21:37:26 -0400
Received: from mail-qt0-f194.google.com ([209.85.216.194]:34814 "EHLO
        mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751375AbdHGBhY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 6 Aug 2017 21:37:24 -0400
MIME-Version: 1.0
In-Reply-To: <1501404235-9105-1-git-send-email-arvind.yadav.cs@gmail.com>
References: <1501404235-9105-1-git-send-email-arvind.yadav.cs@gmail.com>
From: Masanori Goto <gotom@debian.or.jp>
Date: Mon, 7 Aug 2017 10:37:03 +0900
X-Google-Sender-Auth: PrmobHAVjaU6kQoeX5dbXfELd3c
Message-ID: <CALZLnaFDqcigXOt1kYAwpDsVTqn4YX+VDMyFDB6oaXmutkVASg@mail.gmail.com>
Subject: Re: [PATCH 21/29] scsi: nsp32: constify pci_device_id.
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: martin.petersen@oracle.com, jejb@linux.vnet.ibm.com,
        Michael Reed <mdr@sgi.com>, hare@suse.com, aacraid@adaptec.com,
        Matthew Wilcox <matthew@wil.cx>, fthain@telegraphics.com.au,
        schmitzmic@gmail.com, kashyap.desai@broadcom.com,
        sumit.saxena@broadcom.com, mrochs@linux.vnet.ibm.com,
        QLogic-Storage-Upstream@cavium.com, jinpu.wang@profitbricks.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1109
Lines: 32

2017-07-30 17:43 GMT+09:00 Arvind Yadav <arvind.yadav.cs@gmail.com>:
>
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Thank you!  (resending it twice due to an error)

Acked-by: Masanori Goto <gotom@debian.or.jp>


> ---
>  drivers/scsi/nsp32.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c
> index 53c8477..1430b3c 100644
> --- a/drivers/scsi/nsp32.c
> +++ b/drivers/scsi/nsp32.c
> @@ -76,7 +76,7 @@ static const char *nsp32_release_version = "1.2";
>  /****************************************************************************
>   * Supported hardware
>   */
> -static struct pci_device_id nsp32_pci_table[] = {
> +static const struct pci_device_id nsp32_pci_table[] = {
>         {
>                 .vendor      = PCI_VENDOR_ID_IODATA,
>                 .device      = PCI_DEVICE_ID_NINJASCSI_32BI_CBSC_II,
> --
> 2.7.4