Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752140AbdHGHbj (ORCPT ); Mon, 7 Aug 2017 03:31:39 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:48142 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbdHGHbi (ORCPT ); Mon, 7 Aug 2017 03:31:38 -0400 From: "Reizer, Eyal" To: Julian Calaby CC: Kalle Valo , ",Tony Lindgren" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "sebastian.reichel@collabora.co.uk" Subject: RE: [v4] wlcore: add missing nvs file name info for wilink8 Thread-Topic: [v4] wlcore: add missing nvs file name info for wilink8 Thread-Index: AQHTCdj8st8eVKqcBkqatQUq5pUTSKJtnrUggAeJrACAA2IQ0A== Date: Mon, 7 Aug 2017 07:31:28 +0000 Message-ID: <8665E2433BC68541A24DFFCA87B70F5B3641E254@DFRE01.ent.ti.com> References: <1501490529-3360-1-git-send-email-eyalr@ti.com> <8665E2433BC68541A24DFFCA87B70F5B364144B7@DFRE01.ent.ti.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.167.188.93] x-exclaimer-md-config: f9c360f5-3d1e-4c3c-8703-f45bf52eff6b Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v777VmdL016124 Content-Length: 2947 Lines: 67 > -----Original Message----- > From: Julian Calaby [mailto:julian.calaby@gmail.com] > Sent: Saturday, August 5, 2017 8:51 AM > To: Reizer, Eyal > Cc: Kalle Valo; ,Tony Lindgren; linux-wireless@vger.kernel.org; linux- > kernel@vger.kernel.org; sebastian.reichel@collabora.co.uk > Subject: Re: [v4] wlcore: add missing nvs file name info for wilink8 > > Hi Eyal, > > On Mon, Jul 31, 2017 at 6:45 PM, Reizer, Eyal wrote: > > The following commits: > > c815fde wlcore: spi: Populate config firmware data > > d776fc8 wlcore: sdio: Populate config firmware data > > > > Populated the nvs entry for wilink6 and wilink7 only while it is > > still needed for wilink8 as well. > > This broke user space backward compatibility when upgrading from older > > kernels, as the alternate mac address would not be read from the nvs that > > is present in the file system (lib/firmware/ti-connectivity/wl1271-nvs.bin) > > causing mac address change of the wlan interface. > > > > This patch fix this and update the structure field with the same default > > nvs file name that has been used before. > > > > In addition, some distros hold a default wl1271-nvs.bin in the file > > system with a bogus mac address (deadbeef...) that for a wl18xx device > > also overrides the mac address that is stored inside the device. > > Warn users about this bogus mac address and use a random mac instead > > > > Cc: stable > > Signed-off-by: Eyal Reizer > > --- > > > > diff --git a/drivers/net/wireless/ti/wlcore/main.c > b/drivers/net/wireless/ti/wlcore/main.c > > index 60aaa85..7ce4221 100644 > > --- a/drivers/net/wireless/ti/wlcore/main.c > > +++ b/drivers/net/wireless/ti/wlcore/main.c > > @@ -5961,6 +5961,22 @@ static void wl12xx_derive_mac_addresses(struct > wl1271 *wl, u32 oui, u32 nic) > > if (nic + WLCORE_NUM_MAC_ADDRESSES - wl->num_mac_addr > > 0xffffff) > > wl1271_warning("NIC part of the MAC address wraps around!"); > > > > + if (oui == 0xdeadbe && nic == 0xef0000) { > > + wl1271_warning("Detected unconfigured mac address in nvs.\n" > > + "Using a random TI mac address instead.\n" > > + "in case of using a wl12xx device, your " > > + "device performance may not be optimized.\n" > > + "Please use the calibrator tool to configure " > > + "your device.\n" > > + "When using a wl18xx device the nvs file can " > > + "be removed as a default mac address is " > > + "stored internally.\n"); > > + > > + /* Use TI oui and a random nic */ > > + oui = 0x080028; > > Is there (or should there be) a constant for this? Thanks for the comment. Submitting v5 fixing this. Best Regards, Eyal