Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbdHGHiN (ORCPT ); Mon, 7 Aug 2017 03:38:13 -0400 Received: from muru.com ([72.249.23.125]:56942 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752092AbdHGHiM (ORCPT ); Mon, 7 Aug 2017 03:38:12 -0400 Date: Mon, 7 Aug 2017 00:38:09 -0700 From: Tony Lindgren To: "Reizer, Eyal" Cc: Kalle Valo , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "sebastian.reichel@collabora.co.uk" , Julian Calaby Subject: Re: [v5] wlcore: add missing nvs file name info for wilink8 Message-ID: <20170807073808.GD5487@atomide.com> References: <1502090869-8833-1-git-send-email-eyalr@ti.com> <8665E2433BC68541A24DFFCA87B70F5B3641E25B@DFRE01.ent.ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8665E2433BC68541A24DFFCA87B70F5B3641E25B@DFRE01.ent.ti.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1184 Lines: 28 * Reizer, Eyal [170807 00:32]: > The following commits: > c815fde wlcore: spi: Populate config firmware data > d776fc8 wlcore: sdio: Populate config firmware data > > Populated the nvs entry for wilink6 and wilink7 only while it is > still needed for wilink8 as well. > This broke user space backward compatibility when upgrading from older > kernels, as the alternate mac address would not be read from the nvs that is > present in the file system (lib/firmware/ti-connectivity/wl1271-nvs.bin) > causing mac address change of the wlan interface. > > This patch fix this and update the structure field with the same default > nvs file name that has been used before. > > In addition, some distros hold a default wl1271-nvs.bin in the file > system with a bogus mac address (deadbeef...) that for a wl18xx device > also overrides the mac address that is stored inside the device. > Warn users about this bogus mac address and use a random mac instead Hmm looks pretty good to me except for one more thing I just noticed. Why don't you just use the hardware mac address instead of a random mac address on wl18xx device when you see a bogus nvs file? Regards, Tony