Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752243AbdHGH5V (ORCPT ); Mon, 7 Aug 2017 03:57:21 -0400 Received: from mail-wr0-f173.google.com ([209.85.128.173]:37045 "EHLO mail-wr0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752014AbdHGH5T (ORCPT ); Mon, 7 Aug 2017 03:57:19 -0400 Date: Mon, 7 Aug 2017 08:57:16 +0100 From: Lee Jones To: Hoeze Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix missing PCI ID (thanks to CoolStar); Necessary for Lenovo Yoga 720-15 Touchpad Message-ID: <20170807075716.42f7cwfeosanapvk@dell> References: <20170801014715.27708-1-git.ich@frhoelzlwimmer.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170801014715.27708-1-git.ich@frhoelzlwimmer.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1510 Lines: 46 Subject line looks wrong. To see the format expected please use: `git log --oneline -- drivers/mfd` You are missing your SoB. > --- > This patch fixes a missing PCI ID which is necessary for the Lenovo Yoga 720-15 Touchpad to work. This should be in the commit log above. > See this bug report on Launchpad: > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1700657 Drop external links to LP please. > Many thanks to CoolStar, who found this solution! This should be a "Reported-by". Please see Documentation/SubmittingPatches' for more details. > drivers/mfd/intel-lpss-pci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c > index 16ffeaeb1385..867df181d475 100644 > --- a/drivers/mfd/intel-lpss-pci.c > +++ b/drivers/mfd/intel-lpss-pci.c > @@ -208,6 +208,7 @@ static const struct pci_device_id intel_lpss_pci_ids[] = { > { PCI_VDEVICE(INTEL, 0xa12a), (kernel_ulong_t)&spt_info }, > { PCI_VDEVICE(INTEL, 0xa160), (kernel_ulong_t)&spt_i2c_info }, > { PCI_VDEVICE(INTEL, 0xa161), (kernel_ulong_t)&spt_i2c_info }, > + { PCI_VDEVICE(INTEL, 0xa162), (kernel_ulong_t)&spt_i2c_info }, The tabbing looks wrong here. > { PCI_VDEVICE(INTEL, 0xa166), (kernel_ulong_t)&spt_uart_info }, > /* KBL-H */ > { PCI_VDEVICE(INTEL, 0xa2a7), (kernel_ulong_t)&spt_uart_info }, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog