Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752408AbdHGIZz (ORCPT ); Mon, 7 Aug 2017 04:25:55 -0400 Received: from mx02-sz.bfs.de ([194.94.69.103]:40812 "EHLO mx02-sz.bfs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989AbdHGIZx (ORCPT ); Mon, 7 Aug 2017 04:25:53 -0400 Message-ID: <5988240C.1050702@bfs.de> Date: Mon, 07 Aug 2017 10:25:48 +0200 From: walter harms Reply-To: wharms@bfs.de User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: Christophe JAILLET CC: sathya.prakash@broadcom.com, chaitra.basappa@broadcom.com, suganath-prabu.subramani@broadcom.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] scsi: mpt3sas: Fix memory allocation failure test in 'mpt3sas_base_attach()' References: <20170806225134.27079-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20170806225134.27079-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1460 Lines: 44 Am 07.08.2017 00:51, schrieb Christophe JAILLET: > In the lines above this test, 8 'kzalloc' are performed, but only 7 results > are tested. > > Add the missing one (i.e. '!ioc->port_enable_cmds.reply'). > > Signed-off-by: Christophe JAILLET > --- > drivers/scsi/mpt3sas/mpt3sas_base.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c > index 1a5b6e40fb5c..8a44636ab0b5 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_base.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c > @@ -5494,10 +5494,10 @@ mpt3sas_base_attach(struct MPT3SAS_ADAPTER *ioc) > ioc->ctl_cmds.status = MPT3_CMD_NOT_USED; > mutex_init(&ioc->ctl_cmds.mutex); > > - if (!ioc->base_cmds.reply || !ioc->transport_cmds.reply || > - !ioc->scsih_cmds.reply || !ioc->tm_cmds.reply || > - !ioc->config_cmds.reply || !ioc->ctl_cmds.reply || > - !ioc->ctl_cmds.sense) { > + if (!ioc->base_cmds.reply || !ioc->port_enable_cmds.reply || > + !ioc->transport_cmds.reply || !ioc->scsih_cmds.reply || > + !ioc->tm_cmds.reply || !ioc->config_cmds.reply || > + !ioc->ctl_cmds.reply || !ioc->ctl_cmds.sense) { > r = -ENOMEM; > goto out_free_resources; > } obviously it is better to follow the pattern "malloc() , check". Even the programmer lost track. Bonus points if you malloc the buffers in one step. just my 2 cents, re, wh