Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752707AbdHGJKV (ORCPT ); Mon, 7 Aug 2017 05:10:21 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:35622 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752299AbdHGJKT (ORCPT ); Mon, 7 Aug 2017 05:10:19 -0400 MIME-Version: 1.0 X-Originating-IP: [2a02:168:5640:0:960b:2678:e223:c1c6] In-Reply-To: <20170803155207.GA941@mbp> References: <1501761585-11757-1-git-send-email-cakturk@gmail.com> <1501761585-11757-13-git-send-email-cakturk@gmail.com> <87lgn0hm7a.fsf@nikula.org> <20170803124903.sirv43l7i3lgor3x@phenom.ffwll.local> <20170803155207.GA941@mbp> From: Daniel Vetter Date: Mon, 7 Aug 2017 11:10:18 +0200 X-Google-Sender-Auth: iDMSpyITn_z_8TKRG-em3NkL7GY Message-ID: Subject: Re: [PATCH 12/29] drm/i915: switch to drm_*{get,put} helpers To: Cihangir Akturk Cc: Jani Nikula , intel-gfx , Linux Kernel Mailing List , dri-devel , Daniel Vetter Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1585 Lines: 34 On Thu, Aug 3, 2017 at 5:52 PM, Cihangir Akturk wrote: > On Thu, Aug 03, 2017 at 02:49:03PM +0200, Daniel Vetter wrote: >> On Thu, Aug 03, 2017 at 03:26:01PM +0300, Jani Nikula wrote: >> > On Thu, 03 Aug 2017, Cihangir Akturk wrote: >> > > drm_*_reference() and drm_*_unreference() functions are just >> > > compatibility alias for drm_*_get() and drm_*_put() adn should not be >> > > used by new code. So convert all users of compatibility functions to use >> > > the new APIs. >> > >> > Please include the cocci script in the commit message. If you didn't use >> > cocci, you should check it out! :) >> >> Yeah I assume you've created these with spatch/cocci, not with your own >> script. I trust cocci a lot more than any kind of scripting, and the >> coccie patch is already in there kernel (the commits you've cited in the >> cover letter contain it iirc). > > I wrote a simple shell script, which you can see in the cover letter. > But you are right I take function list from scripts/coccinelle/api/drm-get-put.cocci > file. > > Daniel Should I use coccinelle to generate patches and resend a v2? > If so, do i need to include reviewed-by and acked-by tags to patches myself? I think regenerating the patches using cocci would be great, I trust cocci a lot more than random scripts. And cocci is a great tool to learn anyway (if you don't know it yet). If the resulting patches match, you can keep the r-b/a-b tags for v2. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch