Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752791AbdHGJYy (ORCPT ); Mon, 7 Aug 2017 05:24:54 -0400 Received: from mail-io0-f169.google.com ([209.85.223.169]:36648 "EHLO mail-io0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752331AbdHGJYv (ORCPT ); Mon, 7 Aug 2017 05:24:51 -0400 MIME-Version: 1.0 In-Reply-To: <20170801092404.GA30136@localhost> References: <1499374158-12388-1-git-send-email-agust@denx.de> <1499374158-12388-3-git-send-email-agust@denx.de> <20170801092404.GA30136@localhost> From: Linus Walleij Date: Mon, 7 Aug 2017 11:24:50 +0200 Message-ID: Subject: Re: [PATCH 2/3] gpio: Add FT232H CBUS GPIO driver To: Johan Hovold Cc: Anatolij Gustschin , Lee Jones , Alan Tull , Moritz Fischer , "linux-gpio@vger.kernel.org" , linux-fpga@vger.kernel.org, "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 975 Lines: 23 On Tue, Aug 1, 2017 at 11:24 AM, Johan Hovold wrote: > On Tue, Aug 01, 2017 at 08:49:02AM +0200, Linus Walleij wrote: >> On Thu, Jul 6, 2017 at 10:49 PM, Anatolij Gustschin wrote: >> >> > Add driver for CBUS pins on FT232H. The driver supports setting >> > GPIO direction and getting/setting CBUS 0-3 pin value. The CBUS >> > pins have to be enabled by configuring I/O mode in the FTDI EEPROM. >> > >> > Signed-off-by: Anatolij Gustschin > >> Apart from these small things it looks like a solid and nice driver, >> do you plan to merge this into MFD or should I merge it? Since it depends >> on the Kconfig symbol I guess I can merge it orthogonally if I am sure >> Lee will pick the MFD part. > > There are some fundamental problems with this series which prevents it > from being merged. Please take a look at the discussion following patch > 1/3. Allright it is on hold pending the MFD discussion. Yours, Linus Walleij