Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752757AbdHGJ3i (ORCPT ); Mon, 7 Aug 2017 05:29:38 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36179 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752489AbdHGJ3g (ORCPT ); Mon, 7 Aug 2017 05:29:36 -0400 Subject: Re: [PATCH] hwmon: adt7475: wusbhc: constify attribute_group structures. To: Jean Delvare , linux@roeck-us.net References: <1502097950.4007.82.camel@suse.de> Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org From: Arvind Yadav Message-ID: <776b8628-fed1-4cd9-d5dc-60f340203393@gmail.com> Date: Mon, 7 Aug 2017 14:59:18 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1502097950.4007.82.camel@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2386 Lines: 51 Hi, On Monday 07 August 2017 02:55 PM, Jean Delvare wrote: > Hi Arvind, > > On lun., 2017-08-07 at 11:49 +0530, Arvind Yadav wrote: >> attribute_group are not supposed to change at runtime. All functions >> working with attribute_group provided by work with >> const attribute_group. So mark the non-const structs as const. > Confused by the subject. What is "wusbhc:"? > > Also please avoid trailing dot in mail subjects. Thanks for review, I will update. >> Signed-off-by: Arvind Yadav >> --- >> drivers/hwmon/adt7475.c | 16 ++++++++-------- >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c >> index 1baa213..9ef8499 100644 >> --- a/drivers/hwmon/adt7475.c >> +++ b/drivers/hwmon/adt7475.c >> @@ -1319,14 +1319,14 @@ static SENSOR_DEVICE_ATTR_2(pwm3_stall_disable, S_IRUGO | S_IWUSR, >> NULL >> }; >> >> -static struct attribute_group adt7475_attr_group = { .attrs = adt7475_attrs }; >> -static struct attribute_group fan4_attr_group = { .attrs = fan4_attrs }; >> -static struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs }; >> -static struct attribute_group in0_attr_group = { .attrs = in0_attrs }; >> -static struct attribute_group in3_attr_group = { .attrs = in3_attrs }; >> -static struct attribute_group in4_attr_group = { .attrs = in4_attrs }; >> -static struct attribute_group in5_attr_group = { .attrs = in5_attrs }; >> -static struct attribute_group vid_attr_group = { .attrs = vid_attrs }; >> +static const struct attribute_group adt7475_attr_group = { .attrs = adt7475_attrs }; >> +static const struct attribute_group fan4_attr_group = { .attrs = fan4_attrs }; >> +static const struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs }; >> +static const struct attribute_group in0_attr_group = { .attrs = in0_attrs }; >> +static const struct attribute_group in3_attr_group = { .attrs = in3_attrs }; >> +static const struct attribute_group in4_attr_group = { .attrs = in4_attrs }; >> +static const struct attribute_group in5_attr_group = { .attrs = in5_attrs }; >> +static const struct attribute_group vid_attr_group = { .attrs = vid_attrs }; >> >> static int adt7475_detect(struct i2c_client *client, >> struct i2c_board_info *info) > Looks good to me. > > Reviewed-by: Jean Delvare > ~arvind