Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751809AbdHGMtT (ORCPT ); Mon, 7 Aug 2017 08:49:19 -0400 Received: from mail-io0-f174.google.com ([209.85.223.174]:37576 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751364AbdHGMtQ (ORCPT ); Mon, 7 Aug 2017 08:49:16 -0400 MIME-Version: 1.0 In-Reply-To: <1501763123-20486-1-git-send-email-chenjh@rock-chips.com> References: <1501762841-20262-1-git-send-email-chenjh@rock-chips.com> <1501763123-20486-1-git-send-email-chenjh@rock-chips.com> From: Linus Walleij Date: Mon, 7 Aug 2017 14:49:14 +0200 Message-ID: Subject: Re: [PATCH v8 08/12] pinctrl: Add pinctrl driver for the RK805 PMIC To: Joseph Chen Cc: Alexandre Courbot , Dmitry Torokhov , "open list:ARM/Rockchip SoC..." , "linux-kernel@vger.kernel.org" , Tao Huang , Tony Xie , zhangqing@rock-chips.com, David Wu , "devicetree@vger.kernel.org" , w.egorov@phytec.de, Liam Girdwood , Mark Brown , Rob Herring , Mark Rutland , "linux-gpio@vger.kernel.org" , Linux Input Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 611 Lines: 17 On Thu, Aug 3, 2017 at 2:25 PM, Joseph Chen wrote: > RK805 is one of Rockchip PMICs family, it has 2 output only GPIOs. > > This driver is also designed for other Rockchip PMICs to expend. > Different PMIC maybe have different pin features, for example, > RK816 has one pin which can be used for TS or GPIO(input/out). > The mainly difference between PMICs pins are pinmux, direction > and output value, that is 'struct rk805_pin_config'. > > Signed-off-by: Joseph Chen Looks good to me. Acked-by: Linus Walleij Yours, Linus Walleij