Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752035AbdHGNJP (ORCPT ); Mon, 7 Aug 2017 09:09:15 -0400 Received: from mail.ispras.ru ([83.149.199.45]:50256 "EHLO mail.ispras.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751564AbdHGNJO (ORCPT ); Mon, 7 Aug 2017 09:09:14 -0400 Subject: Re: [PATCH] loop: fix to a race condition due to the early registration of device To: Johannes Thumshirn Cc: tom.leiming@gmail.com, axboe@fb.com, osandov@fb.com, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, ldv-project@linuxtesting.org, khoroshilov@ispras.ru References: <1502109470-2945-1-git-send-email-avolkov@ispras.ru> <20170807125413.GZ3978@linux-x5ow.site> From: Anton Volkov Message-ID: Date: Mon, 7 Aug 2017 16:09:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170807125413.GZ3978@linux-x5ow.site> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 472 Lines: 21 This is more of a style-oriented suggestion. This kind of template is commonly used in other modules. Regards, Anton On 07.08.2017 15:54, Johannes Thumshirn wrote: > On Mon, Aug 07, 2017 at 03:37:50PM +0300, Anton Volkov wrote: >> +err_out: >> return err; > > Any reason you can't just use return err; at the respective callsites? > > Thanks, > Johannes > -- Anton Volkov Linux Verification Center, ISPRAS web: http://linuxtesting.org e-mail: avolkov@ispras.ru