Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751864AbdHGNVD (ORCPT ); Mon, 7 Aug 2017 09:21:03 -0400 Received: from mail-pg0-f54.google.com ([74.125.83.54]:36714 "EHLO mail-pg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751247AbdHGNVB (ORCPT ); Mon, 7 Aug 2017 09:21:01 -0400 Subject: Re: [PATCH] platform/x86: ideapad-laptop: Expose conservation mode switch To: Andy Shevchenko Cc: Platform Driver , "linux-kernel@vger.kernel.org" , Darren Hart , Ike Panhc References: <264a8ced-4336-06b9-d760-babc08ccde5c@angelsl.xyz> From: Hao Wei Tee Message-ID: <1476ed74-04ff-e321-ad0f-17126f386dd0@in04.sg> Date: Mon, 7 Aug 2017 21:20:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:55.0) Gecko/20100101 Thunderbird/55.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1566 Lines: 36 On 7/8/2017 02:35, Andy Shevchenko wrote: > On Sat, Aug 5, 2017 at 6:18 PM, Hao Wei Tee wrote: >> On 30/5/2017 21:22, Andy Shevchenko wrote: >>> On Sun, May 28, 2017 at 4:47 PM, Hao Wei Tee wrote: >>>> On 5/27/17 3:31 PM, Hao Wei Tee wrote: >>>>> This exposes the battery conservation mode present on some (?) IdeaPads. >>>>> The mode is set by calling ACPI method SBMC with argument 3 (on) or >>>>> 5 (off). Status is reported in bit 5 of the return value of ACPI method >>>>> GBMD. >>>>> >>>>> This patch was written based on an IdeaPad U430p. I'm not sure if the ACPI >>>>> methods are the same across all IdeaPads, so it would be great if this got more >>>>> testing across other models before it's merged. >>>> >>>> I got someone to test on an IdeaPad Y510p. It works on that too. >>> >>> Do we have any other option that expose something via sysfs? >> >> It's been 2 months, what can I do to get this patch merged, or alternatively some other >> way of exposing this switch? > > Oh, sorry, I was pretty sure I have done something regarding to this > patch, but apparently not. > > I'm fine with the change as long as we have no other option than sysfs here. As far as I can tell most ACPI-related things are exposed via sysfs, and I think we only have sysfs and ioctl to expose things like this anyway (correct me if I'm wrong, please). > I'm on vacation for few more days, I will return to this after (ping > me let's say next Friday if you want to). Sorry for disturbing your vacation! Thanks again. -- Hao Wei